Skip to content

[MTT-11940] Fix: Rate Limited exceeded bug (same profile used join session via name) #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Elfi0Kuhndorf
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf commented Apr 30, 2025

… error

Description

When trying to join a lobby session with the same profile as already within the existing profile instead of an error being thrown mentioning that the user would see the spinning wheel until two more users join and then get a rate limit excpection error.

Now instead immediately an error (UI message) gets thrown once the user tries to join the session and the user can continue to interact with the game after closing the error message ingame.

How to test:

  1. Connect to project id in project settings
  2. Go into play mode create a new profile within the "Change profile" screen, then leave play mode
  3. Activate Player 2 in MPPM and after its activated start play mode
  4. Switch to newly created profile (change profile button) and create a session (start session button, then create session there)
  5. With Player 2 change to same profile via switch profile and try to join session via name (click on name visible in list)
  6. Witness error popping up "Already joined session (sessionName)"

Issue Number(s)

https://jira.unity3d.com/browse/MTT-11940

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@Elfi0Kuhndorf Elfi0Kuhndorf marked this pull request as ready for review April 30, 2025 10:18
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner April 30, 2025 10:18
@sentinel-u3d sentinel-u3d bot requested a review from RikuTheFuffs April 30, 2025 13:08
@fernando-cortez fernando-cortez added 4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. DO NOT MERGE Do not merge this PR! labels Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-On Hold PR can't proceed because it's blocked or is otherwise waiting on something. DO NOT MERGE Do not merge this PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants