-
Notifications
You must be signed in to change notification settings - Fork 12
Make RC configurator thread local #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make RC configurator thread local #276
Conversation
|
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Not sure if I am making the situation worse. The issue is I think generated by threads modifying rc values which causes issues with other tests. The tests that we were initially failing are in particular moddifying the rc and causing issues. Will need to return to this as this has high priority now. |
I suspect that matplotlib itself would need to be thread safe in order for this to work. My guess is that it is not. Maybe try an approach where we force a small subset of the tests to be done serially? |
That could indeed be the case, but I think the edits all go through this configurator object. This would mean that if we protect it, the matplotlib rc file would be protected too. I will go back now and check the thread safety as I was a bit hazzy when I looked at this last night. |
ed13154
to
5129f15
Compare
I need to separate the initialising of the colormaps before this can be fixed more to follow soon. |
Attempt to fix the discrepancies between the tests by putting a read lock on the config properties.