Revert xdist addition #277
Merged
+197
−2,064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @beckermr just to have a second set of eyes on this to be sure that the reversion is going correctly. |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
beckermr
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts:
And keeps these commits on #276.
The reason for this revert is that I have suspicions that there is a racing condition on the writing and or reading on the RC params. I will need to properly isolate this dictionary to be able to add xdist reliable. In order to not halt other PRs or development this will go back to staging rather than keeping the error live. Will continue to work on it, as it believe it is a minor thing that needs addressing for it to work properly but for now let's roll the dev changes back.