Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to set player names in party->tournament again #909

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

barbeque-squared
Copy link
Member

see #901

this allows people to set playernames in partymode again.

@basisbit basisbit merged commit 5468dbc into master Oct 11, 2024
5 checks passed
@basisbit basisbit deleted the fix-tournament-nameinput branch October 11, 2024 19:20
@KanciatyManiek
Copy link

Hello,
I checked the installer and portable versions and it still works, only deleting names, not entering... It works well in the v2023.12.0 portable version provided by barbeque-squared

@barbeque-squared
Copy link
Member Author

@KanciatyManiek it works for me in 2024.10.0 on both Linux and Windows. I even went to all the other party modes (well, except the one that I can't even open) and regardless of whether I select the player name fields with the mouse or the arrow keys, I can backspace and type new names.

If this is about the names shown on the screen while singing: that was never fixed and we are aware of it.

@KanciatyManiek
Copy link

@barbeque-squared I went in to check again and it actually worked :) I don't know if it's the W11 update that happened in the meantime, or other miracles, but it works :) And after updating to UDSX 2024.10 it didn't work, maybe some cache... Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants