Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft release notes for 2024.10.0 #912

Closed
barbeque-squared opened this issue Oct 12, 2024 · 6 comments
Closed

Draft release notes for 2024.10.0 #912

barbeque-squared opened this issue Oct 12, 2024 · 6 comments

Comments

@barbeque-squared
Copy link
Member

barbeque-squared commented Oct 12, 2024

Draft notes are below the horizontal line. Other remarks:

  • I've removed the upcoming breaking change about 8/12 players since it never worked anyway. It also appears to be impossible to change IMaxPlayerCount without completely breaking USDX, so expect a PR that just removes them from the menu options soon.
  • Intended to be released on Sun Oct 13
  • Note to self: change publish time on the website PR

📈 Enhancements

🪲 Bug Fixes

Other Changes

@s09bQ5
Copy link
Collaborator

s09bQ5 commented Oct 12, 2024

Does 6 player mode work reliably? There is a screenshot on our website showing that mode that is also used on Flathub.

@basisbit
Copy link
Member

basisbit commented Oct 12, 2024

6 players mode has worked well since before the project migrated from Sourceforge to GitHub. It is the most common usage mode at any of the bigger events I attend. You better not break that 😝

@barbeque-squared
Copy link
Member Author

I didn't say anything about 6 lol. 6 works fine in both single and multi screen. It's 8 and 12 that don't work. But the correct way would not only remove 8 and 12 from the player options, it should also change IMaxPlayerCount, but doing so leads to very unrelated errors, and also the game becoming Portuguese or something. I just haven't figured out what else (aside from lua functions) is abusing it.

But this is getting very offtopic for a release ticket, once I have some time I'll create a proper ticket.

@barbeque-squared
Copy link
Member Author

hmmm that's an issue:
https://github.com/UltraStar-Deluxe/USDX/actions/runs/11298115383/job/31460549445
Mac doesn't appear to want to build, it probably has something to do with FFmpeg 7. Unfortunately I don't have anything Mac so aside from yolo'ing whatever number it's complaining about to some super high number, I can't fix this.

I guess release is blocked until this is fixed.

@s09bQ5
Copy link
Collaborator

s09bQ5 commented Oct 13, 2024

Should be fixed by #914

@barbeque-squared
Copy link
Member Author

All steps of the release have been completed / related PRs merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants