Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAMS-282 restrict data verification #884

Merged
merged 14 commits into from
Sep 11, 2024
Merged

CAMS-282 restrict data verification #884

merged 14 commits into from
Sep 11, 2024

Conversation

btposey
Copy link
Contributor

@btposey btposey commented Sep 10, 2024

Purpose

Restrict data verification to users assigned the data verification role.

Major Changes

  • Added guard to header to dynamically show/hide the data verification navigation.
  • Added logic to API to throw unauthorized errors if an unauthorized user attempts to reject/approve orders.
  • Appended current user in context to audit records.
  • Show user in audit detail (existing logic)

Testing/Validation

Unit tests above coverage threshold.

Definition of Done:

  • Acceptance criteria met - The system meets all acceptance criteria
  • Feature toggles created - Features that are deployed but not released have toggles
  • Design QA passed - All visual UI looks and works the way it’s supposed to
  • Usability validated - Team ensures the working code is easy to use
  • Accessibility tests passed - System passes automated and manual accessibility tests and supports applicable devices
  • Code refactored for clarity - Developers can understand the work simply by reviewing the code
  • Dependency Rule followed - More important code doesn’t directly depend on less important code
  • Development debt eliminated - UX and code aligns to the team’s latest understanding of the domain
  • Source code merged - Code has been merged into the main branch
  • 90% unit test coverage achieved - Automated test coverage tools indicate coverage of >= 90%
  • Code reviewed - Code is reviewed by at least two other team members before being merged
  • Code quality checks passed - Code passes all automated quality checks
  • Security scans passed - Code passes expected scans for vulnerabilities and compliance issues
  • Threat model updated - The threat model incorporates new threats and remediations
  • Build process updated - Automated build process include code supporting the user story
  • Load/performance tests passed - Performance tests include the functionality of the user story
  • Documents are updated - All required documentation is up to date and version controlled
  • Code is deployed - Code is deployed to the highest production like environment

@btposey btposey requested review from a team as code owners September 10, 2024 15:07
@btposey btposey changed the title Cams 282 restrict data verification CAMS-282 restrict data verification Sep 10, 2024
fmaddenflx and others added 3 commits September 10, 2024 11:09
@fmaddenflx @amorrow-flexion
@jamesobrooks @btposey
Data verification restricted by user group
9019fbe 
* Restricted orders query by offices assigned to the user in context
* Only data verification users can approve or reject orders
* Order audit history shows user who approved transfer or consolidation
* Sync orders adds division code to case details

Jira ticket: CAMS-282

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: James Brooks <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@fmaddenflx @jamesobrooks @btposey
Fixed bug related to front end 500 error alert
60cb5a4 
api2 patch was not expecting an empty response

Jira ticket: CAMS-282

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: James Brooks <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@amorrow-flexion @jamesobrooks @btposey
fixed endpoint in manual sync tests
ac7bd89 
Jira ticket: CAMS-282

Co-authored-by: James Brooks <[email protected]>
@btposey btposey force-pushed the CAMS-282-restrict-data-verification branch from 6788a5d to ac7bd89 Compare September 10, 2024 15:09
@jamesobrooks @fmaddenflx @amorrow-flexion
Fix tests
ea48aef 
Jira ticket: CAMS-282

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@jamesobrooks @fmaddenflx
Grant the SUPERUSER all roles and offices
0f6279f 
Jira ticket: CAMS-282

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
fmaddenflx and others added 4 commits September 10, 2024 15:02
@fmaddenflx @jamesobrooks
Moved timestamp and user into createCaseHistory
ab22fb5 
Jira ticket: CAMS-282
@btposey @fmaddenflx
@amorrow-flexion @jamesobrooks
Refactor API to use Auditable type
45c30c3 
* Added Auditable and createAuditRecord to common
* Updated each record that records an update time and user to use the Auditable type

Jira ticket: CAMS-282

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: James Brooks <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@jamesobrooks @fmaddenflx @amorrow-flexion
Update UI with updatedBy and updatedOn properties
faca3d9 
Jira ticket: CAMS-282

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@btposey
Merge pull request #885 from US-Trustee-Program/CAMS-282-restrict-dat…
306965a 
…a-verification-fritz

CAMS-282 restrict data verification fritz
@jamesobrooks
Apply suggestions from code review
4305fb3 
Formatting and linting issues.
@jamesobrooks @fmaddenflx @amorrow-flexion
Modify mock patchTransferOrder to return void
1782cc8 
Jira ticket: CAMS-282

Co-authored-by: Fritz Madden <[email protected]>
Co-authored-by: Arthur Morrow <[email protected]>
Co-authored-by: Brian Posey <[email protected]>,
@jamesobrooks
Fix type issue in PendingTransferOrder.test.tsx
8739e09 
Jira ticket: CAMS-282

Co-authored-by: Brian Posey <[email protected]>,
@amorrow-flexion
removed outdated comments
af686ed 
Jira ticket: CAMS-282
@btposey btposey merged commit 927208e into main Sep 11, 2024
14 checks passed
@btposey btposey deleted the CAMS-282-restrict-data-verification branch September 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorrow-flexion amorrow-flexion amorrow-flexion left review comments

@jamesobrooks jamesobrooks jamesobrooks left review comments

@fmaddenflx fmaddenflx fmaddenflx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@btposey @jamesobrooks @fmaddenflx @amorrow-flexion