Merge pull request #884 from US-Trustee-Program/CAMS-282-restrict-dat…

…a-verification CAMS-282 restrict data verification
US-Trustee-Program · Sep 11, 2024 · 927208e · 927208e
2 parents ed0637a + af686ed
commit 927208e
Show file tree

Hide file tree

Showing 42 changed files with 667 additions and 220 deletions.
diff --git a/backend/functions/lib/adapters/gateways/case.assignment.cosmosdb.repository.test.ts b/backend/functions/lib/adapters/gateways/case.assignment.cosmosdb.repository.test.ts
@@ -32,7 +32,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: clairHuxtable,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
     const testCaseAttorneyAssignment2: CaseAssignment = {
       documentType: 'ASSIGNMENT',
@@ -41,7 +42,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: perryMason,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     const assignmentId1 = await repository.createAssignment(testCaseAttorneyAssignment1);
@@ -75,7 +77,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: clairHuxtable,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     const actualIdResponse = await repository.createAssignment(testCaseAttorneyAssignment);
@@ -98,7 +101,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: clairHuxtable,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     await repository.createAssignment(existingCaseAttorneyAssignment);
@@ -110,7 +114,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: benMatlock,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     await expect(repository.updateAssignment(testCaseAttorneyAssignment)).rejects.toThrow(
@@ -128,7 +133,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: clairHuxtable,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
     const testCaseAttorneyAssignment2: CaseAssignment = {
       documentType: 'ASSIGNMENT',
@@ -137,7 +143,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: perryMason,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     const assignmentId1 = await repository.createAssignment(testCaseAttorneyAssignment1);
@@ -176,7 +183,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: benMatlock,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     await expect(repository.createAssignment(testCaseAttorneyAssignment)).rejects.toThrow(
@@ -222,7 +230,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: perryMason,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
     const testCaseAttorneyAssignment2: CaseAssignment = {
       documentType: 'ASSIGNMENT',
@@ -231,7 +240,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: benMatlock,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     const caseIdTwo = randomUUID();
@@ -242,7 +252,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: clairHuxtable,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
     const testCaseAttorneyAssignment4: CaseAssignment = {
       documentType: 'ASSIGNMENT',
@@ -251,7 +262,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: perryMason,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     const caseIdThree = randomUUID();
@@ -262,7 +274,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: clairHuxtable,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
     const testCaseAttorneyAssignment6: CaseAssignment = {
       documentType: 'ASSIGNMENT',
@@ -271,7 +284,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: benMatlock,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     await repository.createAssignment(testCaseAttorneyAssignment1);
@@ -362,7 +376,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: clairHuxtable,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     await expect(repository.createAssignment(existingCaseAttorneyAssignment)).rejects.toThrow(
@@ -379,7 +394,8 @@ describe('Test case assignment cosmosdb repository tests', () => {
       name: benMatlock,
       role: CamsRole.TrialAttorney,
       assignedOn: currentDate,
-      changedBy: MockData.getCamsUserReference(),
+      updatedOn: currentDate,
+      updatedBy: MockData.getCamsUserReference(),
     };
 
     await expect(repository.updateAssignment(testCaseAttorneyAssignment)).rejects.toThrow(

diff --git a/backend/functions/lib/adapters/gateways/cases.cosmosdb.repository.test.ts b/backend/functions/lib/adapters/gateways/cases.cosmosdb.repository.test.ts
@@ -12,6 +12,7 @@ import {
 import { AggregateAuthenticationError } from '@azure/identity';
 import { CaseAssignmentHistory } from '../../../../../common/src/cams/history';
 import { MockData } from '../../../../../common/src/cams/test-utilities/mock-data';
+import { SYSTEM_USER_REFERENCE } from '../../../../../common/src/cams/auditable';
 
 describe('Runtime State Repo', () => {
   const caseId1 = '111-11-11111';
@@ -122,7 +123,8 @@ describe('Test case history cosmosdb repository tests', () => {
     const testCaseAssignmentHistory: CaseAssignmentHistory = {
       caseId,
       documentType: 'AUDIT_ASSIGNMENT',
-      occurredAtTimestamp: new Date().toISOString(),
+      updatedOn: new Date().toISOString(),
+      updatedBy: SYSTEM_USER_REFERENCE,
       before: [],
       after: [],
     };
@@ -137,7 +139,8 @@ describe('Test case history cosmosdb repository tests', () => {
     const testCaseAssignmentHistory: CaseAssignmentHistory = {
       caseId,
       documentType: 'AUDIT_ASSIGNMENT',
-      occurredAtTimestamp: new Date().toISOString(),
+      updatedBy: SYSTEM_USER_REFERENCE,
+      updatedOn: new Date().toISOString(),
       before: [],
       after: [],
     };

diff --git a/backend/functions/lib/adapters/gateways/cases.cosmosdb.repository.ts b/backend/functions/lib/adapters/gateways/cases.cosmosdb.repository.ts
@@ -110,9 +110,6 @@ export class CasesCosmosDbRepository implements CasesRepository {
 
   async createCaseHistory(context: ApplicationContext, history: CaseHistory): Promise<string> {
     try {
-      if (!history.occurredAtTimestamp) {
-        history.occurredAtTimestamp = new Date().toISOString();
-      }
       const { resource } = await this.cosmosDbClient
         .database(this.cosmosConfig.databaseName)
         .container(this.containerName)

diff --git a/backend/functions/lib/adapters/gateways/consolidations.cosmosdb.repository.ts b/backend/functions/lib/adapters/gateways/consolidations.cosmosdb.repository.ts
@@ -1,3 +1,4 @@
+import { OrdersSearchPredicate } from '../../../../../common/src/api/search';
 import { ConsolidationOrder } from '../../../../../common/src/cams/orders';
 import { ConsolidationOrdersRepository } from '../../use-cases/gateways.types';
 import { ApplicationContext } from '../types/basic';
@@ -13,11 +14,30 @@ export default class ConsolidationOrdersCosmosDbRepository
   constructor(context: ApplicationContext) {
     super(context, CONTAINER_NAME, MODULE_NAME);
   }
-  public async getAll(context: ApplicationContext): Promise<Array<ConsolidationOrder>> {
-    const querySpec = {
-      query: 'SELECT * FROM c ORDER BY c.orderDate ASC',
-      parameters: [],
-    };
+  public async search(
+    context: ApplicationContext,
+    predicate?: OrdersSearchPredicate,
+  ): Promise<Array<ConsolidationOrder>> {
+    let querySpec;
+    if (!predicate) {
+      querySpec = {
+        query: 'SELECT * FROM c ORDER BY c.orderDate ASC',
+        parameters: [],
+      };
+    } else {
+      // TODO: Sanitize the inputs
+      // Group designator comes from local-storage-gateway and is store in the user session cache.
+      // We get associated division codes from DXTR and also store that in the session cache.
+      // We are not ever trusting the client with this information as of 9 Sept 2024.
+      const whereClause =
+        'WHERE ' +
+        predicate.divisionCodes.map((dCode) => `c.courtDivisionCode='${dCode}'`).join(' OR ') +
+        ' ORDER BY c.orderDate ASC';
+      querySpec = {
+        query: 'SELECT * FROM c ' + whereClause,
+        parameters: [],
+      };
+    }
     return await this.query(context, querySpec);
   }
 }
diff --git a/backend/functions/lib/adapters/gateways/dxtr/orders.dxtr.gateway.ts b/backend/functions/lib/adapters/gateways/dxtr/orders.dxtr.gateway.ts
@@ -409,6 +409,7 @@ export class DxtrOrdersGateway implements OrdersGateway {
         CS.CS_SHORT_TITLE AS caseTitle,
         CS.CS_CHAPTER AS chapter,
         C.COURT_NAME AS courtName,
+        CS.CS_DIV as courtDivisionCode,
         O.OFFICE_NAME_DISPLAY AS courtDivisionName,
         G.REGION_ID AS regionId,
         R.REGION_NAME AS regionName,

diff --git a/backend/functions/lib/adapters/gateways/orders.cosmosdb.repository.test.ts b/backend/functions/lib/adapters/gateways/orders.cosmosdb.repository.test.ts
@@ -48,7 +48,7 @@ describe('Test case assignment cosmosdb repository tests', () => {
       resources: mockOrders,
     });
 
-    const testResult = await repository.getOrders(applicationContext);
+    const testResult = await repository.search(applicationContext);
 
     expect(testResult).toEqual(mockOrders);
     expect(mockFetchAll).toHaveBeenCalled();
@@ -227,7 +227,7 @@ describe('Test case assignment cosmosdb repository tests', () => {
     jest.spyOn(MockHumbleItems.prototype, 'create').mockRejectedValue(aggregateError);
     jest.spyOn(MockHumbleItem.prototype, 'read').mockRejectedValue(aggregateError);
 
-    await expect(repository.getOrders(applicationContext)).rejects.toThrow(serverConfigError);
+    await expect(repository.search(applicationContext)).rejects.toThrow(serverConfigError);
     await expect(
       repository.getOrder(applicationContext, testNewOrderData.id, testNewOrderData.caseId),
     ).rejects.toThrow(serverConfigError);
@@ -245,7 +245,7 @@ describe('Test case assignment cosmosdb repository tests', () => {
     jest.spyOn(MockHumbleItem.prototype, 'read').mockRejectedValue(error);
     jest.spyOn(MockHumbleItems.prototype, 'create').mockRejectedValue(error);
 
-    await expect(repository.getOrders(applicationContext)).rejects.toThrow(error);
+    await expect(repository.search(applicationContext)).rejects.toThrow(error);
     await expect(
       repository.getOrder(applicationContext, testNewOrderData.id, testNewOrderData.caseId),
     ).rejects.toThrow(error);

diff --git a/backend/functions/lib/adapters/gateways/orders.cosmosdb.repository.ts b/backend/functions/lib/adapters/gateways/orders.cosmosdb.repository.ts
@@ -10,6 +10,7 @@ import { Order, TransferOrder, TransferOrderAction } from '../../../../../common
 import CosmosClientHumble from '../../cosmos-humble-objects/cosmos-client-humble';
 import { MockHumbleClient } from '../../testing/mock.cosmos-client-humble';
 import { QueryOptions } from '../../cosmos-humble-objects/cosmos-items-humble';
+import { OrdersSearchPredicate } from '../../../../../common/src/api/search';
 
 const MODULE_NAME: string = 'COSMOS_DB_REPOSITORY_ORDERS';
 const CONTAINER_NAME: string = 'orders';
@@ -32,12 +33,27 @@ export class OrdersCosmosDbRepository implements OrdersRepository {
     this.moduleName = moduleName;
   }
 
-  async getOrders(context: ApplicationContext): Promise<Order[]> {
-    const query = 'SELECT * FROM c ORDER BY c.orderDate ASC';
-    const querySpec = {
-      query,
-      parameters: [],
-    };
+  async search(context: ApplicationContext, predicate?: OrdersSearchPredicate): Promise<Order[]> {
+    let querySpec;
+    if (!predicate) {
+      querySpec = {
+        query: 'SELECT * FROM c ORDER BY c.orderDate ASC',
+        parameters: [],
+      };
+    } else {
+      // TODO: Sanitize the inputs
+      // Group designator comes from local-storage-gateway and is store in the user session cache.
+      // We get associated division codes from DXTR and also store that in the session cache.
+      // We are not ever trusting the client with this information as of 9 Sept 2024.
+      const whereClause =
+        'WHERE ' +
+        predicate.divisionCodes.map((dCode) => `c.courtDivisionCode='${dCode}'`).join(' OR ') +
+        ' ORDER BY c.orderDate ASC';
+      querySpec = {
+        query: 'SELECT * FROM c ' + whereClause,
+        parameters: [],
+      };
+    }
     const response = await this.queryData<Order>(context, querySpec);
     return response;
   }

diff --git a/backend/functions/lib/adapters/gateways/storage/local-storage-gateway.test.ts b/backend/functions/lib/adapters/gateways/storage/local-storage-gateway.test.ts
@@ -1,4 +1,8 @@
-import LocalStorageGateway, { OFFICE_MAPPING_PATH } from './local-storage-gateway';
+import LocalStorageGateway, {
+  OFFICE_MAPPING_PATH,
+  ROLE_MAPPING_PATH,
+} from './local-storage-gateway';
+import { CamsRole } from '../../../../../../common/src/cams/roles';
 
 describe('map get', () => {
   test('should return appropriate string for valid path', () => {
@@ -8,4 +12,19 @@ describe('map get', () => {
   test('should return null for invalid path', () => {
     expect(LocalStorageGateway.get('INVALID_PATH')).toBeNull();
   });
+
+  test('should include case assignment manager role', () => {
+    const roleMap = LocalStorageGateway.get(ROLE_MAPPING_PATH);
+    expect(roleMap).toContain(CamsRole.CaseAssignmentManager);
+  });
+
+  test('should include trial attorney role', () => {
+    const roleMap = LocalStorageGateway.get(ROLE_MAPPING_PATH);
+    expect(roleMap).toContain(CamsRole.TrialAttorney);
+  });
+
+  test('should include data verification role', () => {
+    const roleMap = LocalStorageGateway.get(ROLE_MAPPING_PATH);
+    expect(roleMap).toContain(CamsRole.DataVerifier);
+  });
 });
diff --git a/backend/functions/lib/adapters/gateways/storage/local-storage-gateway.ts b/backend/functions/lib/adapters/gateways/storage/local-storage-gateway.ts
@@ -8,7 +8,8 @@ export const ROLE_MAPPING_PATH = '/rolemapping.csv';
 const ROLE_MAPPING =
   'ad_group_name,idp_group_name,cams_role\n' +
   'USTP_CAMS_Case_assignment_Manager,USTP CAMS Case Assignment Manager,CaseAssignmentManager\n' +
-  'USTP_CAMS_Trial_Attorney,USTP CAMS Trial Attorney,TrialAttorney\n';
+  'USTP_CAMS_Trial_Attorney,USTP CAMS Trial Attorney,TrialAttorney\n' +
+  'USTP_CAMS_Data_Verifier,USTP CAMS Data Verifier,DataVerifier\n';
 
 export const OFFICE_MAPPING_PATH = '/officemapping.csv';
 const OFFICE_MAPPING =

diff --git a/backend/functions/lib/controllers/orders/orders.controller.ts b/backend/functions/lib/controllers/orders/orders.controller.ts
@@ -60,7 +60,7 @@ export class OrdersController implements CamsController {
         return this.handleConsolidations(context);
       case 'orders':
         return this.handleOrders(context);
-      case 'order-manual-sync':
+      case 'orders-sync':
         return this.handleOrderSync(context);
       case 'orders-suggestions':
         return this.handleOrdersSuggestions(context);

diff --git a/backend/functions/lib/cosmos-humble-objects/fake.assignments.cosmos-client-humble.ts b/backend/functions/lib/cosmos-humble-objects/fake.assignments.cosmos-client-humble.ts
@@ -46,7 +46,8 @@ export default class FakeAssignmentsCosmosClientHumble {
                   name: 'Test Attorney',
                   role: 'TrialAttorney',
                   assignedOn: '2024-03-05',
-                  changedBy: MockData.getCamsUserReference(),
+                  updatedOn: '2024-03-05',
+                  updatedBy: MockData.getCamsUserReference(),
                 };
               }
               assignment.id = `assignment-id-${Math.round(Math.random() * 1000)}`;

diff --git a/backend/functions/lib/testing/local-data/local-consolidation-orders-repository.ts b/backend/functions/lib/testing/local-data/local-consolidation-orders-repository.ts
@@ -2,12 +2,16 @@ import { ConsolidationOrder } from '../../../../../common/src/cams/orders';
 import { ApplicationContext } from '../../adapters/types/basic';
 import { ConsolidationOrdersRepository } from '../../use-cases/gateways.types';
 import { LocalCosmosDbRepository } from './local-cosmos-db-repository';
+import { OrdersSearchPredicate } from '../../../../../common/src/api/search';
 
 export class LocalConsolidationOrdersRepository
   extends LocalCosmosDbRepository<ConsolidationOrder>
   implements ConsolidationOrdersRepository
 {
-  async getAll(_context: ApplicationContext): Promise<ConsolidationOrder[]> {
+  async search(
+    _context: ApplicationContext,
+    _predicate?: OrdersSearchPredicate,
+  ): Promise<ConsolidationOrder[]> {
     return [...this.container];
   }
 }