i18n: make <kbd> tags translatable #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton) here I've merged the two existing translations, as it otherwise splits them up in an awkward way for translations - which also caused some mistranslations already. that way it also would've made it impossible to translate for RTL languages.
had to create a separate entry here, as the "add_link" property got reused in the dialog title and the button
eliandoran
approved these changes
Dec 29, 2024
There was a problem hiding this comment.
Seems like a good start for now.
There are still things that moving keyboard shortcuts into translation won't solve, such as rewriting Super into ⌘ for macOS, but we can deal with them later.
Ideally for me, the shortcut keys should be a separate field for context menus and the shortcut is translated via a service (which will split it into components, but also apply platform-specific changes such as the previously mentioned super key).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This fixes #820, by moving the tags into the translation strings.
What I did NOT do though, is fix the keyboard commands that come from the
keyboard_actionsfile – I've opened up a separate issue for this, as it requires a different approach IMHO than for these tags here.I tried to move the kbd tags into the current translations as well, using previously used translations of these kbd tags as reference where possible.