Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][LOGIC REFINE]change from suicide to recycle. #664

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[WIP][LOGIC REFINE]change from suicide to recycle. #664

wants to merge 7 commits into from

Conversation

XenoAmess
Copy link
Contributor

@XenoAmess XenoAmess commented Sep 7, 2022 •
edited
Loading

close #658

@XenoAmess XenoAmess force-pushed the After_claiming,_turn_claimer_to_a_reserver_or_a_scout,_instead_of_kill_it_ branch 2 times, most recently from 617c978 to 9700015 Compare September 8, 2022 01:28
@XenoAmess XenoAmess changed the title [LOGIC REFINE]after claiming, turn claimer to a reserver or a scout, instead of kill it. change from suicide to recycle. Sep 8, 2022
@XenoAmess XenoAmess changed the title change from suicide to recycle. [LOGIC REFINE]change from suicide to recycle. Sep 8, 2022
@XenoAmess XenoAmess force-pushed the After_claiming,_turn_claimer_to_a_reserver_or_a_scout,_instead_of_kill_it_ branch 4 times, most recently from 8ec2132 to 51294b9 Compare September 8, 2022 17:50
mschultheiss83
mschultheiss83 suggested changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@mschultheiss83 mschultheiss83 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check Creep.recycleCreep prototype_creep_startup_tasks.js:101

screeps/src/prototype_creep_startup_tasks.js

Line 101 in 8240847

Creep.recycleCreep = function(creep) {

please use the exiting function

@XenoAmess XenoAmess force-pushed the After_claiming,_turn_claimer_to_a_reserver_or_a_scout,_instead_of_kill_it_ branch 2 times, most recently from cf85f76 to 8d47bc1 Compare September 9, 2022 17:00
mschultheiss83
mschultheiss83 suggested changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@mschultheiss83 mschultheiss83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess patching the Creep.recycleCreep function would be necessary
creep.memory.timeToTravel > 0 && creep.memory.born - Game.time < creep.memory.timeToTravel
and let the recycleCreep decide between suicide and recycle

src/prototype_creep.js Show resolved Hide resolved
src/prototype_creep.js Show resolved Hide resolved
src/prototype_creep_clean.js Outdated Show resolved Hide resolved
src/prototype_room_controller.js Show resolved Hide resolved
src/role_carry.js Outdated Show resolved Hide resolved
src/role_carry.js Outdated Show resolved Hide resolved
src/role_claimer.js Show resolved Hide resolved
src/role_quester.js Show resolved Hide resolved
src/role_quester.js Show resolved Hide resolved
@XenoAmess XenoAmess changed the title [LOGIC REFINE]change from suicide to recycle. [WIP][LOGIC REFINE]change from suicide to recycle. Sep 10, 2022
@XenoAmess XenoAmess force-pushed the After_claiming,_turn_claimer_to_a_reserver_or_a_scout,_instead_of_kill_it_ branch 4 times, most recently from 3faccb0 to 2437f49 Compare September 14, 2022 13:10
@XenoAmess XenoAmess force-pushed the After_claiming,_turn_claimer_to_a_reserver_or_a_scout,_instead_of_kill_it_ branch from 0ae5855 to 9693007 Compare September 27, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschultheiss83 mschultheiss83 mschultheiss83 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LOGIC REFINE] After claiming, turn claimer to a reserver or a scout, instead of kill it.
2 participants
@XenoAmess @mschultheiss83