fixed the issue in strings/join.py #12434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms-keeper
bot
added
tests are failing
|
Added corresponding doctest |
|
@RajdeepBakolia2004 Please fill pull_request_template that I added to the end of your PR description @cclauss We don't have any problems with automatic PRs closing by the robot if there is no template or nothing is filled in there? My PR #12450 was closed as invalid when I forgot to fill template, but I see some opened recent PRs with the same problem |
MaximSmolskiy
requested changes
Dec 29, 2024
algorithms-keeper
bot
added
awaiting changes
|
sure thank you for reminding me
…________________________________
From: Maxim Smolskiy ***@***.***>
Sent: 29 December 2024 18:23
To: TheAlgorithms/Python ***@***.***>
Cc: Rajdeep Bakolia ***@***.***>; Mention ***@***.***>
Subject: Re: [TheAlgorithms/Python] fixed the issue in strings/join.py (PR #12434)
External Email
@MaximSmolskiy requested changes on this pull request.
Please fix my comment above
—
Reply to this email directly, view it on GitHub<#12434 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCL2ZK27UTSPWLSXGASSQQ32H7WDLAVCNFSM6AAAAABTSB4BAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRUHE2DCNBYGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
We want PRs to be autoclosed for no checkboxes are checked to limit spam PRs. Maintainers should be able to reopen closed PRs. |
MaximSmolskiy
approved these changes
Dec 29, 2024
There was a problem hiding this comment.
@RajdeepBakolia2004 Thanks for fix, tried to make it more elegant and shorter
algorithms-keeper
bot
removed
the
awaiting changes
|
Thank you 🙂
…________________________________
From: Maxim Smolskiy ***@***.***>
Sent: 29 December 2024 19:05
To: TheAlgorithms/Python ***@***.***>
Cc: Rajdeep Bakolia ***@***.***>; Mention ***@***.***>
Subject: Re: [TheAlgorithms/Python] fixed the issue in strings/join.py (PR #12434)
External Email
@MaximSmolskiy approved this pull request.
@RajdeepBakolia2004<https://github.com/RajdeepBakolia2004> Thanks for fix, tried to make it more elegant and shorter
—
Reply to this email directly, view it on GitHub<#12434 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCL2ZKYIGGMDQTUSTDPLDZL2H73ANAVCNFSM6AAAAABTSB4BAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRUHE2DQNRZGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This was referenced Dec 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that join() function was not working as the join method of string due to strip method which truncates from end
now whenever we have empty strings in our separated list it was just adding multiple terminator and all the terminator where getting strip which was different form the join method so a for loop was run for the entire list except the last element in which case it just add the last element and it also take care of the case when the list is empty
It fixes the bug in the join.py file
Fixes #12408
Describe your change:
Checklist: