fixed the issue in strings/join.py

[RajdeepBakolia2004]

The issue was that join() function was not working as the join method of string due to strip method which truncates from end
now whenever we have empty strings in our separated list it was just adding multiple terminator and all the terminator where getting strip which was different form the join method so a for loop was run for the entire list except the last element in which case it just add the last element and it also take care of the case when the list is empty

It fixes the bug in the join.py file

Fixes #12408

Describe your change:

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

[MaximSmolskiy]

Added corresponding doctest

[MaximSmolskiy]

@RajdeepBakolia2004 Please fill pull_request_template that I added to the end of your PR description

@cclauss We don't have any problems with automatic PRs closing by the robot if there is no template or nothing is filled in there? My PR #12450 was closed as invalid when I forgot to fill template, but I see some opened recent PRs with the same problem

[MaximSmolskiy]

Please fix my comment above

[RajdeepBakolia2004]

sure thank you for reminding me

…

________________________________ From: Maxim Smolskiy ***@***.***> Sent: 29 December 2024 18:23 To: TheAlgorithms/Python ***@***.***> Cc: Rajdeep Bakolia ***@***.***>; Mention ***@***.***> Subject: Re: [TheAlgorithms/Python] fixed the issue in strings/join.py (PR #12434) External Email @MaximSmolskiy requested changes on this pull request. Please fix my comment above — Reply to this email directly, view it on GitHub<#12434 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCL2ZK27UTSPWLSXGASSQQ32H7WDLAVCNFSM6AAAAABTSB4BAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRUHE2DCNBYGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[cclauss]

We want PRs to be autoclosed for no checkboxes are checked to limit spam PRs. Maintainers should be able to reopen closed PRs.

[MaximSmolskiy]

We want PRs to be autoclosed for no checkboxes are checked to limit spam PRs. Maintainers should be able to reopen closed PRs.

@cclauss But why PR #12455 with no checkboxes are checked was not autoclosed?

[MaximSmolskiy]

@RajdeepBakolia2004 Thanks for fix, tried to make it more elegant and shorter

[RajdeepBakolia2004]

Thank you 🙂

…

________________________________ From: Maxim Smolskiy ***@***.***> Sent: 29 December 2024 19:05 To: TheAlgorithms/Python ***@***.***> Cc: Rajdeep Bakolia ***@***.***>; Mention ***@***.***> Subject: Re: [TheAlgorithms/Python] fixed the issue in strings/join.py (PR #12434) External Email @MaximSmolskiy approved this pull request. @RajdeepBakolia2004<https://github.com/RajdeepBakolia2004> Thanks for fix, tried to make it more elegant and shorter — Reply to this email directly, view it on GitHub<#12434 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCL2ZKYIGGMDQTUSTDPLDZL2H73ANAVCNFSM6AAAAABTSB4BAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRUHE2DQNRZGU>. You are receiving this because you were mentioned.Message ID: ***@***.***>