Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix join file error #12410

Closed
wants to merge 4 commits into from
Closed

Fix join file error #12410

wants to merge 4 commits into from

Conversation

osman-haider
Copy link

@osman-haider osman-haider commented Dec 3, 2024 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes strings/join.py is incorrect #12408".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Dec 3, 2024
Davidak643h
Davidak643h suggested changes Dec 8, 2024
View reviewed changes
Copy link

@Davidak643h Davidak643h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e490d13c4a3dbbeea15eadf4e2bcf92b8b02cad6

@MaximSmolskiy
Copy link
Member

Reversed split changes

@MaximSmolskiy
Copy link
Member

@osman-haider Point of this repository is to learn how to implement algorithms and built-in functions yourself, so I can't accept implementation of join function using built-in Python join method

@MaximSmolskiy MaximSmolskiy self-requested a review December 29, 2024 12:50
MaximSmolskiy
MaximSmolskiy requested changes Dec 29, 2024
View reviewed changes
Copy link
Member

@MaximSmolskiy MaximSmolskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix my comment above

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Dec 29, 2024
@MaximSmolskiy
Copy link
Member

Closed in favor of #12434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximSmolskiy MaximSmolskiy MaximSmolskiy requested changes

@Davidak643h Davidak643h Davidak643h requested changes

Assignees
No one assigned
Labels
awaiting changes A maintainer has requested changes to this PR enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strings/join.py is incorrect
3 participants
@osman-haider @MaximSmolskiy @Davidak643h