Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/register-photo-ui] 사진 등록 UI 구성 #82
[feature/register-photo-ui] 사진 등록 UI 구성 #82
Changes from all commits
9580ab8
ee9c3e4
2d06d6e
360d5ee
eea42a2
666e936
b57e2ce
a6ae753
15cf511
3f47475
3c85299
ce8eb4c
59169b7
10e586c
ae939a6
8587ad1
eacfe3c
1a7c865
20b1801
f930ae2
fec2f6f
63d3b63
59516fc
c40f7b7
90d3a55
da08ac8
4876955
0915d54
2163b22
d207620
ca28a3e
3fd5fd7
7078723
925312f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currentAlbum을 observalbe한 변수가 아닌 nullable한 변수로 지정한 이유가 있을까요?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
얘를 변경감지해서 사용할 수 있는 부분이 딱히 없어서 collect 하는 걸 제외했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jpg, png만 따로 처리하는 부분이 ImageOnly 상수인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵넵