[feature/register-photo-ui] 사진 등록 UI 구성 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librarywon
approved these changes
Jul 6, 2023
l2hyunwoo
force-pushed
the
feature/register-photo-ui
branch
2 times, most recently
from
4b8fad0
to
cefa77c
Compare
l2hyunwoo
force-pushed
the
feature/register-photo-ui
branch
from
5fbf289
to
90d3a55
Compare
kez-lab
reviewed
Jul 7, 2023
Comment on lines
+6
to
+12
| class HomeViewModel : ViewModel() { | ||
| var currentAlbum: AlbumItem? = null | ||
| private set | ||
|
|
||
| fun onUpdateAlbum(album: AlbumItem?) { | ||
| currentAlbum = album | ||
| } |
There was a problem hiding this comment.
currentAlbum을 observalbe한 변수가 아닌 nullable한 변수로 지정한 이유가 있을까요?!
There was a problem hiding this comment.
얘를 변경감지해서 사용할 수 있는 부분이 딱히 없어서 collect 하는 걸 제외했습니다.
Comment on lines
+51
to
+53
| binding.bottomNavFav.setOnClickListener { | ||
| imagePicker.launch(PickVisualMediaRequest(ActivityResultContracts.PickVisualMedia.ImageOnly)) | ||
| } |
There was a problem hiding this comment.
jpg, png만 따로 처리하는 부분이 ImageOnly 상수인가요?
Comment on lines
+80
to
+99
| val currentCreatedAt = viewModel.createdAt.value | ||
| val picker = MaterialDatePicker.Builder | ||
| .datePicker() | ||
| .setTheme(R.style.ThemeOverlay_Pophory_MaterialCalendar) | ||
| .setInputMode(MaterialDatePicker.INPUT_MODE_CALENDAR) | ||
| .setCalendarConstraints( | ||
| CalendarConstraints.Builder() | ||
| .setValidator( | ||
| DateValidatorPointBackward.now() | ||
| ) | ||
| .setEnd(Instant.systemNow().toEpochMilliseconds()).build() | ||
| ) | ||
| .setSelection( | ||
| currentCreatedAt + TimeZone.getDefault().getOffset(currentCreatedAt) | ||
| ) | ||
| .build() | ||
| picker.show(supportFragmentManager, "datePicker") | ||
| picker.addOnPositiveButtonClickListener(viewModel::onUpdateCreateAt) | ||
| } | ||
|
|
app/src/main/java/com/teampophory/pophory/feature/home/photo/AddPhotoViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/teampophory/pophory/feature/home/photo/AddPhotoViewModel.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 코드