Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 타임블록 바 퍼블리싱 #328
[Feat] 타임블록 바 퍼블리싱 #328
Changes from all commits
1790819
4eb43b9
f604030
8769653
e656fa6
fb53034
0a45d11
38db838
24b1086
7f52f99
33987b7
c7ce363
9dbf34c
5141d17
12a6502
49cf458
7aa6420
9750b7a
725c6c7
05a91eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
header 태그 사용해주는 건 어떨까요 ? 타임블록 바의 헤더 역할을 하는 부분 같아서요 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 고민해봤는데 저는 헤더라고 보기에는 그냥 바에서 정보를 전달하는 컴포넌트 중 하나라는 생각이 들어서 헤더를 안 주는게 맞다는 생각이 들었어요! 혹시 헤더 역할을 하는 부분이라고 생각하신 이유를 알 수 있을까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
동의합니당 ~ 공식문서에서 header는 "소개 및 탐색에 도움을 주는 콘텐츠"에 사용한다고 하네요. 물론 어떻게 생각해보면 해당할 수도 있지만, 딱 header에 적합하지도 않은 것 같아요 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠 그렇군요 저는 타임 블록 정보들 중 주요한 정보들이라 판단해서 그렇게 의견을 제시했는데 어떻게 보니 header 태그를 사용할 정도는 아니라는 생각이 드네요 !!