Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 타임블록 바 퍼블리싱 #328

Merged
merged 20 commits into from
Nov 20, 2024
Merged

[Feat] 타임블록 바 퍼블리싱 #328

merged 20 commits into from
Nov 20, 2024

Conversation

rtttr1
Copy link
Contributor

@rtttr1 rtttr1 commented Nov 14, 2024

해당 이슈 번호

closed #312

체크리스트

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [feat] PR을 등록한다.
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • ✅ 컨벤션을 지켰나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?
  • 💻 git rebase를 사용했나요?
  • 🙇‍♂️ 리뷰어를 지정했나요?

📌 내가 알게 된 부분

  • display: flex 가 적용된 컴포넌트에는 textOverflow: ellipsis가 적용이 안됩니다~

💎 PR Point

단순 퍼블리싱이었습니다!

📌스크린샷 (선택)

2024-11-14.11.55.05.mov

rtttr1 added 18 commits November 5, 2024 18:52
@rtttr1
feat: 기초 구조 잡기
1790819
@rtttr1
chore: merge develop
4eb43b9
@rtttr1
fix: command button secondary 스타일 추가
f604030
@rtttr1
docs: svg 파일 추가
8769653
@rtttr1
refactor: commandButton style 추가
e656fa6
@rtttr1
feat: timeblock 업로드된 파일 item 구현
fb53034
@rtttr1
feat: TimeBlock 업로드된 파일 컴포넌트 구현
0a45d11
@rtttr1
feat: TimeBlock 태그된 인수인계 노트 item 구현
38db838
@rtttr1
feat: TimeBlock 태그된 인수인계 노트 컴포넌트 구현
24b1086
@rtttr1
feat: TimeBlock info 구현
7f52f99
@rtttr1
feat: TimeBlockBar 컴포넌트 구현
33987b7
@rtttr1
feat: TimeBlockDrawer 컴포넌트 구현
c7ce363
@rtttr1
feat: TimeBlockBar close 버튼 기능 구현
9dbf34c
@rtttr1
feat: 수정하기 뷰 구현
5141d17
@rtttr1
fix: textOverflow 에러 해결
12a6502
@rtttr1
fix: button 공컴 disabled 시 cursor 이벤트 없애기
49cf458
@rtttr1
style: cursor pointer
7aa6420
@rtttr1
refactor: 잔잔바리 수정
9750b7a
@rtttr1 rtttr1 self-assigned this Nov 14, 2024
@github-actions GitHub Actions
Copy link

🚀 Storybook 확인하기 🚀

namdaeun
namdaeun reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@namdaeun namdaeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

퍼블리싱 고생 많으셨습니다 ㅎㅎ👍🏻

src/common/component/Button/Button.style.ts Show resolved Hide resolved
src/common/component/Button/Button.style.ts Outdated Show resolved Hide resolved
src/page/archiving/index/component/TimeBlockBar/BlockInfo/BlockInfo.tsx Outdated Show resolved Hide resolved
src/page/archiving/index/component/TimeBlockBar/TaggedNotes/TaggedNotes.tsx Show resolved Hide resolved
src/page/archiving/index/component/TimeBlockBar/TaggedNotes/TaggedNotes.tsx Outdated Show resolved Hide resolved
src/page/archiving/index/component/TimeBlockBar/BlockInfo/BlockInfo.tsx

const BlockInfo = ({ title, startDate, endDate, isEdit }: BlockInfoProps) => {
return (
<Flex styles={{ direction: 'column', gap: '1rem', marginTop: '1.8rem', width: '100%' }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

header 태그 사용해주는 건 어떨까요 ? 타임블록 바의 헤더 역할을 하는 부분 같아서요 !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음 고민해봤는데 저는 헤더라고 보기에는 그냥 바에서 정보를 전달하는 컴포넌트 중 하나라는 생각이 들어서 헤더를 안 주는게 맞다는 생각이 들었어요! 혹시 헤더 역할을 하는 부분이라고 생각하신 이유를 알 수 있을까요??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동의합니당 ~ 공식문서에서 header는 "소개 및 탐색에 도움을 주는 콘텐츠"에 사용한다고 하네요. 물론 어떻게 생각해보면 해당할 수도 있지만, 딱 header에 적합하지도 않은 것 같아요 !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흠 그렇군요 저는 타임 블록 정보들 중 주요한 정보들이라 판단해서 그렇게 의견을 제시했는데 어떻게 보니 header 태그를 사용할 정도는 아니라는 생각이 드네요 !!

src/page/archiving/index/component/TimeBlockBar/TimeBlockBar.tsx Outdated Show resolved Hide resolved
src/shared/component/TimeBlockDrawer/TimeBlockDrawer.tsx Outdated Show resolved Hide resolved
wuzoo
wuzoo reviewed Nov 17, 2024
View reviewed changes
Copy link
Contributor

@wuzoo wuzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴다 !!!

src/page/archiving/index/component/TimeBlockBar/TaggedNotes/TaggedNotes.tsx Show resolved Hide resolved
src/page/archiving/index/component/TimeBlockBar/TaggedNotes/TaggedNotes.tsx Outdated Show resolved Hide resolved
src/page/archiving/index/component/TimeBlockBar/UploadedFiles/UploadedFiles.tsx Outdated Show resolved Hide resolved
src/page/archiving/index/component/TimeBlockBar/TaggedNotes/TaggedNoteItem/TaggedNoteItem.tsx Outdated Show resolved Hide resolved
src/page/archiving/index/component/TimeBlockBar/TimeBlockBar.tsx Outdated Show resolved Hide resolved
src/page/archiving/index/component/TimeBlockBar/UploadedFiles/FileItem/FileItem.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🚀 Storybook 확인하기 🚀

Bowoon1216
Bowoon1216 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@Bowoon1216 Bowoon1216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제는 달인이 되어버린 규홍님 수고하셨습니다!! LGTM 💯

wuzoo
wuzoo approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@wuzoo wuzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

규홍시 고생고생 !! ~~

src/page/archiving/index/component/TimeBlockBar/BlockInfo/BlockInfo.tsx

const BlockInfo = ({ title, startDate, endDate, isEdit }: BlockInfoProps) => {
return (
<Flex styles={{ direction: 'column', gap: '1rem', marginTop: '1.8rem', width: '100%' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동의합니당 ~ 공식문서에서 header는 "소개 및 탐색에 도움을 주는 콘텐츠"에 사용한다고 하네요. 물론 어떻게 생각해보면 해당할 수도 있지만, 딱 header에 적합하지도 않은 것 같아요 !

namdaeun
namdaeun approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@namdaeun namdaeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 :)

src/page/archiving/index/component/TimeBlockBar/BlockInfo/BlockInfo.tsx

const BlockInfo = ({ title, startDate, endDate, isEdit }: BlockInfoProps) => {
return (
<Flex styles={{ direction: 'column', gap: '1rem', marginTop: '1.8rem', width: '100%' }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흠 그렇군요 저는 타임 블록 정보들 중 주요한 정보들이라 판단해서 그렇게 의견을 제시했는데 어떻게 보니 header 태그를 사용할 정도는 아니라는 생각이 드네요 !!

@rtttr1 rtttr1 merged commit 5b075d9 into develop Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuzoo wuzoo wuzoo approved these changes

@Bowoon1216 Bowoon1216 Bowoon1216 approved these changes

@namdaeun namdaeun namdaeun approved these changes

@cindy-chaewon cindy-chaewon Awaiting requested review from cindy-chaewon

Assignees

@rtttr1 rtttr1

Labels
✨Feature 🍭규홍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlockBar 퍼블리싱
4 participants
@rtttr1 @namdaeun @Bowoon1216 @wuzoo