Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow negative sides #30

Merged
merged 2 commits into from
Jul 20, 2015
Merged

Allow negative sides #30

merged 2 commits into from
Jul 20, 2015

Commits on Jul 19, 2015

  1. Refactor RollerType 

    - Extract `RollerType` to an extension on `Die`.
- Introduce two other rollers (both "signed")
    @brentleyjones
    brentleyjones committed Jul 19, 2015
    Configuration menu
    Copy the full SHA
    eb99d8d View commit details
    Browse the repository at this point in the history

  2. Allow negative sides 

    Most people are going to use positive sides. I don't feel we should burden the caller with handling `throws` since that is the case. One can even make an arguement for accepting negative sides, such as how I implemented `signedClosedRoller`.

With this change I made `signedClosedRoller` the `Die.defaultRoller`.
    @brentleyjones
    brentleyjones committed Jul 19, 2015
    Configuration menu
    Copy the full SHA
    b2843a4 View commit details
    Browse the repository at this point in the history