Allow negative sides #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract `RollerType` to an extension on `Die`. - Introduce two other rollers (both "signed")
Most people are going to use positive sides. I don't feel we should burden the caller with handling `throws` since that is the case. One can even make an arguement for accepting negative sides, such as how I implemented `signedClosedRoller`. With this change I made `signedClosedRoller` the `Die.defaultRoller`.
|
👍 |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most people are going to use positive sides. I don't feel we should burden the caller with handling
throwssince that is the case. One can even make an arguement for accepting negative sides, such as how I implementedsignedClosedRoller.With this change I made
signedClosedRollertheDie.defaultRoller.This is also needed in the long haul to support #29.