Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date is now clickable, if lecture doesn't have a name #1319

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Date is now clickable, if lecture doesn't have a name #1319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eeedd2
Date is now clickable, if lecture doesn't have a name
SebiWrn Jan 23, 2024
34fb23d
Updated date to be normal size if in list view
SebiWrn Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions web/template/home.gohtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,8 +491,17 @@

</a>
</template>
<template x-if="vod.HasName()">
<span class="date text-sm"
x-text="vod.FriendlyDateStart()"></span>
</template>

<template x-if="!vod.HasName()">
<a :class="isListView() ? 'title overflow-hidden' : ''" :href="course.WatchURL(vod.ID)">
<span class="date" :class="isListView() ? '' : 'text-sm'"
x-text="vod.FriendlyDateStart()"></span>
</a>
</template>
</div>
<button type="button" @click="vod.Dropdown.toggle()"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This button is currently too far away from the title... This makes it hard for me to notice that there's a button. Do you think it would be better to place it more to the left?
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would you put it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put it directly to the right of the date, with appropriate padding

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this would cause the button to be at a different position for every entry in the list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true... And I don't think this button is very frequently used (those who click on them a lot will probably find them anyway). I'll approve the change and maybe you can deploy this fix along with (after) the test tonight.

class="md:group-hover:opacity-100 md:opacity-0 px-2">
Expand Down
Loading