Date is now clickable, if lecture doesn't have a name #1319
Conversation
SebiWrn
requested review from
alexanderstephan,
barisgul15,
DawinYurtseven and
YiranDuan721
|
Your Testserver will be ready at https://1319.test.live.mm.rbg.tum.de in a few minutes. Logins
|
|
Yeap, functionally works perfectly, but maybe the date which is also the link can look better. What I mean is that for example the font of the named lecture link is bold and when mouse is on it, a straight line appears under the text which indicates that it is a link. It is also the case for the lecture name links on homepage. |
|
Text now shows up in full size if List View is toggled |
| <span class="date" :class="isListView() ? '' : 'text-sm'" | ||
| x-text="vod.FriendlyDateStart()"></span> | ||
| </a> | ||
| </template> | ||
| </div> | ||
| <button type="button" @click="vod.Dropdown.toggle()" |
There was a problem hiding this comment.
This button is currently too far away from the title... This makes it hard for me to notice that there's a button. Do you think it would be better to place it more to the left?
There was a problem hiding this comment.
Where would you put it?
There was a problem hiding this comment.
I would put it directly to the right of the date, with appropriate padding
There was a problem hiding this comment.
But this would cause the button to be at a different position for every entry in the list
There was a problem hiding this comment.
That's true... And I don't think this button is very frequently used (those who click on them a lot will probably find them anyway). I'll approve the change and maybe you can deploy this fix along with (after) the test tonight.
YiranDuan721
deleted the
1314-when-lectures-are-not-named-you-can-not-click-them-on-list-view
branch
* Date is now clickable, if lecture doesn't have a name * Updated date to be normal size if in list view
Motivation and Context
Fixes #1314
Description
If a lecture doesn't have a name, the date is now clickable so you can select them in list view as well.