Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interface return type and remove unused dummy argument #145

Merged
merged 1 commit into from
May 13, 2024

Conversation

stefabat
Copy link
Contributor

@stefabat stefabat commented May 8, 2024

This PR fixes two problems with the Fortran API that I encountered while integrating TREXIO into CP2K:

  1. The interface to function trexio_info() was returning an integer rather than a c_int32_t. To fix it @scemama and I used the same trick used for function trexio_open.
  2. The subroutine trexio_strarray2str had an unused dummy argument, max_str_len, which we removed from the signature and for the relevant subroutine calls.

@q-posev
Copy link
Member

q-posev commented May 10, 2024

Thanks @stefabat! Would you like me to review the PR or @scemama will take care of it?

@scemama
Copy link
Member

scemama commented May 13, 2024

We did it together, so I would prefer if you could give a quick look ;-)

Copy link
Member

@q-posev q-posev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@q-posev q-posev merged commit cffdef1 into TREX-CoE:master May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants