Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved modern fortran compliance #147

Merged
merged 7 commits into from
May 13, 2024
Merged

Improved modern fortran compliance #147

merged 7 commits into from
May 13, 2024

Conversation

scemama
Copy link
Member

@scemama scemama commented May 13, 2024

This fixes issue #146, please merge this after #145.

Note: The import statement imports the iso_c_binding elements from the module, so use iso_c_binding is not necessary inside the functions.

@scemama scemama requested a review from q-posev May 13, 2024 10:33
@scemama scemama mentioned this pull request May 13, 2024
Closed
q-posev
q-posev approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@q-posev q-posev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
@scemama have you checked that there are no warning printed now with -Wuse-without-only and gfortran?

@q-posev
Copy link
Member

q-posev commented May 13, 2024

Nevermind, my bad...

q-posev
q-posev approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@q-posev q-posev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One-line import

@scemama
Copy link
Member Author

scemama commented May 13, 2024

@q-posev Is it all good now?

@q-posev
Copy link
Member

q-posev commented May 13, 2024

@scemama no, looks like something broke when I merge master with PR #145 into this branch (there was a git conflict which I had to solve). Now the compilations fails at trexio_open_c

@q-posev
Copy link
Member

q-posev commented May 13, 2024

Found it!

@q-posev q-posev merged commit 9e262ba into master May 13, 2024
3 checks passed
@q-posev q-posev deleted the warnings branch May 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@q-posev q-posev q-posev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scemama @q-posev