Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency related build problems by downgrading. #525

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fix dependency related build problems by downgrading. #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28250ff
Fix dependency related build problems by downgrading.
kaladay Sep 11, 2024
3403d25
- Incremented the version to incorporate the npm build fix
rmathew1011 Sep 13, 2024
37f0183
Modified description for cheerio package in CHANGELOG file
rmathew1011 Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
# Changelog

## [2.0.5] - 12-02-22
## [2.0.5-rc.2] - 09-13-24
### Resolves

- Downgrading Angular dependencies to 12.2.16 to fix npm build.
- Added `"cheerio": "1.0.0-rc.10"` to resolve issues with the compodocs command not running correctly.
- Added `"typescript": ">=4.2.3 <4.4"` to fix npm build.
- Added `"whatwg-mimetype": "^3.0.0"` to fix npm build.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice this dependency was explicitly required to override, hence would be incorrect to assert it fixes npm build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what was observed, we were able to get a successful build post addition of these dependencies in the overrides.


## [2.0.5-rc.1] - 12-02-22
### Resolves

- WYSIWYG save is not working. (#516)
Expand Down
27 changes: 16 additions & 11 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"type": "git",
"url": "git+https://github.com/TAMULib/weaver-components.git"
},
"version": "2.0.5-rc.1",
"version": "2.0.5-rc.2",
"private": false,
"license": "MIT",
"engines": {
Expand Down Expand Up @@ -61,11 +61,11 @@
"test:ci": "npm run test:audit && npm run test:coverage"
},
"dependencies": {
"@angular/animations": "12.2.16",
"@angular/elements": "12.2.16",
"@angular/forms": "12.2.16",
"@angular/localize": "12.2.16",
"@angular/platform-browser-dynamic": "12.2.16",
"@angular/animations": "12.2.17",
"@angular/elements": "12.2.17",
"@angular/forms": "12.2.17",
"@angular/localize": "12.2.17",
"@angular/platform-browser-dynamic": "12.2.17",
"@ng-bootstrap/ng-bootstrap": "10.0.0",
"@ngrx/effects": "12.5.1",
"@ngrx/entity": "12.5.1",
Expand All @@ -78,10 +78,10 @@
"tinymce": "6.2.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "12.2.16",
"@angular-devkit/build-angular": "12.2.17",
"@angular-eslint/eslint-plugin": "14.1.2",
"@angular-eslint/eslint-plugin-template": "14.1.2",
"@angular/cli": "12.2.16",
"@angular/cli": "12.2.17",
"@compodoc/compodoc": "1.1.19",
"@lhci/cli": "0.9.0",
"@ngrx/schematics": "12.5.1",
Expand Down Expand Up @@ -126,14 +126,19 @@
"zone.js": "0.11.8"
},
"overrides": {
"@angular/compiler": "12.2.16",
"@angular/core": "12.2.16",
"@angular/compiler": "12.2.17",
"@angular/compiler-cli": "12.2.17",
"@angular/core": "12.2.17",
"@types/eslint": "6.8.1",
"@types/node": "18.11.10",
"cheerio": "1.0.0-rc.10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the dependency that broke compodocs build.

"chokidar": "3.5.3",
"fs-extra": "10.1.0",
"glob": "7.2.3",
"latest-version": "7.0.0",
"selfsigned": "2.1.1",
"tslib": "2.4.0"
"tslib": "2.4.0",
"typescript": ">=4.2.3 <4.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and @types/node are the dependency changes that broke the typescript build.

"whatwg-mimetype": "^3.0.0"
}
}
4 changes: 2 additions & 2 deletions projects/wvr-elements/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@wvr/elements",
"version": "2.0.5-rc.1",
"version": "2.0.5-rc.2",
"description": "Collection of angular components for Weaver's Custom Web Component UI",
"author": "Texas A&M University Libraries",
"private": false,
Expand All @@ -27,7 +27,7 @@
"tslib": "2.4.0"
},
"peerDependencies": {
"@angular/common": "12.2.16",
"@angular/common": "12.2.17",
"handlebars": "4.7.7"
}
}
Loading