Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency related build problems by downgrading. #525

Merged
merged 3 commits into from
Sep 13, 2024

Commits on Sep 11, 2024

  1. Fix dependency related build problems by downgrading.

    I happened to have a 2 year old package lock file.
    Compare and copy and paste several of the versions and problematic packages.
    This could use further review to get the latest but still working versions.
    For now, this is good enough to get things compiling.
    
    The `12.2.16` versions of angular happened to be being pulled down by recent installs but the older package lock file shows `12.2.17`.
    Explicitly set the `12.2.17` in all angular cases.
    
    Several dependencies have warnings like these:
    ```
    npm WARN EBADENGINE Unsupported engine {
    npm WARN EBADENGINE   package: '[email protected]',
    npm WARN EBADENGINE   required: { node: '>=18.17' },
    npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
    npm WARN EBADENGINE }
    npm WARN EBADENGINE Unsupported engine {
    npm WARN EBADENGINE   package: '[email protected]',
    npm WARN EBADENGINE   required: { node: '>=18.17' },
    npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
    npm WARN EBADENGINE }
    npm WARN EBADENGINE Unsupported engine {
    npm WARN EBADENGINE   package: '[email protected]',
    npm WARN EBADENGINE   required: { node: '>=18' },
    npm WARN EBADENGINE   current: { node: 'v16.18.1', npm: '8.19.2' }
    npm WARN EBADENGINE }
    ```
    Downgrade the dependencies to known versions that do build.
    
    I explicitly set the `typescript` version to `>=4.2.3 <4.4` based on some of the contents of the 2 year old package lock file.
    I do not know what is ideal here for the version numbers but this is good enough for now.
    kaladay committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    28250ff View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    3403d25 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37f0183 View commit details
    Browse the repository at this point in the history