Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for .NET 8, NUnit 4.0 #188

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Added support for .NET 8, NUnit 4.0 #188

merged 6 commits into from
Jan 5, 2024

Conversation

daghsentinel
Copy link
Contributor

@daghsentinel daghsentinel commented Nov 30, 2023 •
edited
Loading

  • Added .NET 8 target framework
  • Upgraded to NUnit 4.0 (major) for non-netstandard2.0 targets
  • Removed support for netcoreapp3.1 as this framework is past end-of-life

@swisslife-bot
Copy link
Contributor

swisslife-bot commented Nov 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@daghsentinel
Copy link
Contributor Author

Any chance someone looks into this? Or is this project dead?

@vbreuss vbreuss mentioned this pull request Dec 6, 2023
Merged
1 task
RohrerF
RohrerF reviewed Dec 6, 2023
View reviewed changes
src/Snapshooter.Json/Snapshooter.Json.csproj Outdated Show resolved Hide resolved
src/Dependencies.props Show resolved Hide resolved
test/Snapshooter.Environment.Tests/Snapshooter.Environment.Tests.csproj Outdated Show resolved Hide resolved
src/Snapshooter.NUnit/Snapshooter.NUnit.csproj Outdated Show resolved Hide resolved
@daghsentinel
Copy link
Contributor Author

Bump

@RohrerF
Copy link
Member

RohrerF commented Dec 8, 2023

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@daghsentinel
Copy link
Contributor Author

Looks like there is a problem in Azure pipelines

@daghsentinel
Copy link
Contributor Author

Still noone that can look into this`?

@fgreinacher
Copy link
Contributor

We'd also be happy to see this in ❤️

@RohrerF @PascalSenn Could one of you maybe have a look? 🙇

@Place1
Copy link

Place1 commented Jan 2, 2024

It would be great to get this merged because it breaks the NUnit 4 update due to this: https://docs.nunit.org/articles/nunit/release-notes/Nunit4.0-MigrationGuide.html#using-nunit-extension-libraries

If the project is dead; has anyone already opened a fork?

@RohrerF RohrerF mentioned this pull request Jan 3, 2024
Merged
@RohrerF RohrerF changed the title Added support for .NET 8, Nuget 4.0 Added support for .NET 8, NUnit 4.0 Jan 3, 2024
@RohrerF RohrerF closed this Jan 3, 2024
@RohrerF RohrerF reopened this Jan 3, 2024
@daghsentinel
Copy link
Contributor Author

Sonar exclusions variable seems to be empty - so someone has to enter a value in the configuration or delete the exclusions line from the workflow setup @RohrerF, @PascalSenn

@RohrerF RohrerF mentioned this pull request Jan 5, 2024
Closed
@RohrerF
Copy link
Member

RohrerF commented Jan 5, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RohrerF RohrerF merged commit 4fce39a into SwissLife-OSS:master Jan 5, 2024
3 of 6 checks passed
@RohrerF RohrerF mentioned this pull request Jan 5, 2024
Closed
@fgreinacher fgreinacher mentioned this pull request Jan 8, 2024
Closed
dylan-apollo pushed a commit to apollographql/subgraph-csharp-hotchocolate-annotation that referenced this pull request Jul 10, 2024
@renovate
chore(deps): update dependency snapshooter.xunit to v0.14.1 (#33)
5e95fe3 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [Snapshooter.Xunit](https://togithub.com/SwissLife-OSS/Snapshooter) |
`0.13.0` -> `0.14.1` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Snapshooter.Xunit/0.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Snapshooter.Xunit/0.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Snapshooter.Xunit/0.13.0/0.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Snapshooter.Xunit/0.13.0/0.14.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>SwissLife-OSS/Snapshooter (Snapshooter.Xunit)</summary>

###
[`v0.14.1`](https://togithub.com/SwissLife-OSS/snapshooter/releases/tag/0.14.1)

[Compare
Source](https://togithub.com/SwissLife-OSS/Snapshooter/compare/0.14.0...0.14.1)

##### What's Changed

- Add .NET 4.6.2 target by
[@&#8203;fgreinacher](https://togithub.com/fgreinacher) in
[SwissLife-OSS/snapshooter#195

##### New Contributors

- [@&#8203;fgreinacher](https://togithub.com/fgreinacher) made their
first contribution in
[SwissLife-OSS/snapshooter#195

**Full Changelog**:
SwissLife-OSS/snapshooter@0.14.0...0.14.1

###
[`v0.14.0`](https://togithub.com/SwissLife-OSS/snapshooter/releases/tag/0.14.0)

[Compare
Source](https://togithub.com/SwissLife-OSS/Snapshooter/compare/0.13.0...0.14.0)

##### What's Changed

- Added support for .NET 8, NUnit 4.0 by
[@&#8203;daghsentinel](https://togithub.com/daghsentinel) in
[SwissLife-OSS/snapshooter#188
-   drop support for EOL net3.1

##### New Contributors

- [@&#8203;daghsentinel](https://togithub.com/daghsentinel) made their
first contribution in
[SwissLife-OSS/snapshooter#188

**Full Changelog**:
SwissLife-OSS/snapshooter@0.13.0...0.14.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/apollographql/subgraph-csharp-hotchocolate-annotation).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgreinacher fgreinacher fgreinacher left review comments

@PascalSenn PascalSenn PascalSenn approved these changes

@RohrerF RohrerF RohrerF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@daghsentinel @swisslife-bot @RohrerF @fgreinacher @Place1 @PascalSenn