Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency nunit to v4 #1058

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 26, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
NUnit (source) 3.14.0 -> 4.0.1 age adoption passing confidence

Release Notes

nunit/nunit (NUnit)

v4.0.1: NUnit 4.0.1

Patch release to fix windows targets

See release notes
and
See migration guide

v4.0.0

All changes, see release notes


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@vbreuss
Copy link
Member

vbreuss commented Nov 28, 2023

Please note, that NUnit v4 does not support net461, net5.0 and netcoreapp3.1:

The minimum target framework supported is now dotnet framework 4.6.2, and .net 6.0.

@fgreinacher
Copy link
Contributor

Please note, that NUnit v4 does not support net461, net5.0 and netcoreapp3.1:

The minimum target framework supported is now dotnet framework 4.6.2, and .net 6.0.

Thanks for pointing that out @vbreuss.

Maybe this would be a good opportunity to remove all unsupported .NET versions from our test projects, WDYT?

@vbreuss
Copy link
Member

vbreuss commented Nov 30, 2023

Maybe this would be a good opportunity to remove all unsupported .NET versions from our test projects, WDYT?

Currently we support the following frameworks:

<TargetFrameworks>net8.0;net7.0;net6.0;net5.0;netstandard2.1;netstandard2.0;net461</TargetFrameworks>

I think it is no longer necessary to support, e.g. net5.0 or netcoreapp3.1 in the test projects (and also in the actual projects) as consumers would fall-back to netstandard2.0.

It is more difficult with net461. According to this page:

While NuGet considers .NET Framework 4.6.1 as supporting .NET Standard 1.5 through 2.0, there are several issues with consuming .NET Standard libraries that were built for those versions from .NET Framework 4.6.1 projects. For .NET Framework projects that need to use such libraries, we recommend that you upgrade the project to target .NET Framework 4.7.2 or higher.

So if we remove net461 from the test project, I think we should also update the .NET Framework version in the other projects, which would be a breaking change...

@fgreinacher
Copy link
Contributor

I think we can upgrade to .NET 4.6.2. that one is still supported for a few years, see https://learn.microsoft.com/de-de/lifecycle/products/microsoft-net-framework.

@vbreuss
Copy link
Member

vbreuss commented Dec 4, 2023

I think we can upgrade to .NET 4.6.2. that one is still supported for a few years, see https://learn.microsoft.com/de-de/lifecycle/products/microsoft-net-framework.

I created #1060 to update the supported frameworks.

@renovate renovate bot force-pushed the renovate/nunit-4.x branch 2 times, most recently from 294457a to 3545b85 Compare December 5, 2023 21:12
mergify bot pushed a commit that referenced this pull request Dec 5, 2023
Update frameworks in preparation to support [nunit v4](https://docs.nunit.org/articles/nunit/release-notes/framework.html#nunit-400---november-26-2023):
- Update .NET Framework 4.6.1 to .NET Framework 4.6.2
- Remove no longer supported version .NET 5
- Remove .NET Core 3.1 from test project

Related to #1058

BREAKING CHANGE: .NET Framework 4.6.1 and .NET 5 targets are not available anymore because they are [out of support](https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core).
@renovate renovate bot force-pushed the renovate/nunit-4.x branch 4 times, most recently from f7855b0 to 4289f19 Compare December 5, 2023 23:15
@vbreuss
Copy link
Member

vbreuss commented Dec 6, 2023

Before we can update to NUnit v4 we have to either wait for a new version of Snapshooter (see SwissLife-OSS/snapshooter#188) or find a new way for ApiParityTests.

@fgreinacher
Copy link
Contributor

Before we can update to NUnit v4 we have to either wait for a new version of Snapshooter (see SwissLife-OSS/snapshooter#188) or find a new way for ApiParityTests.

Let's wait a bit, the PR seems to make good progress.

@fgreinacher
Copy link
Contributor

I cherry-picked bc4723f to get the new Snapshooter version.

Copy link
Contributor Author

renovate bot commented Jan 8, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@mergify mergify bot merged commit 83936e6 into main Jan 8, 2024
8 checks passed
@mergify mergify bot deleted the renovate/nunit-4.x branch January 8, 2024 14:39
Copy link

This is addressed in release v20.0.15.

@github-actions github-actions bot added the state: released Issues that are released label Jan 22, 2024
mergify bot pushed a commit to Testably/Testably.Abstractions that referenced this pull request Jan 22, 2024
…20.0.15 (#451)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[TestableIO.System.IO.Abstractions](https://togithub.com/TestableIO/System.IO.Abstractions)
| `20.0.4` -> `20.0.15` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/TestableIO.System.IO.Abstractions/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/TestableIO.System.IO.Abstractions/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/TestableIO.System.IO.Abstractions/20.0.4/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/TestableIO.System.IO.Abstractions/20.0.4/20.0.15?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>TestableIO/System.IO.Abstractions
(TestableIO.System.IO.Abstractions)</summary>

###
[`v20.0.15`](https://togithub.com/TestableIO/System.IO.Abstractions/releases/tag/v20.0.15)

#### What's Changed

- chore(deps): update dependency benchmarkdotnet to v0.13.11 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1066
- refactor: Convert Classic Assert to Constraint Model by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[TestableIO/System.IO.Abstractions#1065
- chore(deps): update actions/upload-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1068
- chore(deps): update actions/download-artifact action to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1067
- chore(deps): update dependency saucecontrol.inheritdoc to v2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1069
- chore(deps): update apexskier/github-release-commenter action to
v1.3.6 by [@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1071
- chore(deps): update dependency benchmarkdotnet to v0.13.12 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1075
- chore(deps): update dependency nunit to v4 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1058
- chore(deps): update dependency dotnet-sdk to v8.0.101 by
[@&#8203;renovate](https://togithub.com/renovate) in
[TestableIO/System.IO.Abstractions#1077
- refactor: remove workaround for Snapshooter/NUnit 4/.NET 4.6.2 compat…
by [@&#8203;fgreinacher](https://togithub.com/fgreinacher) in
[TestableIO/System.IO.Abstractions#1076
- fix: use correct path for wrapped `FileInfo` and `DirectoryInfo` by
[@&#8203;vbreuss](https://togithub.com/vbreuss) in
[TestableIO/System.IO.Abstractions#1079

**Full Changelog**:
TestableIO/System.IO.Abstractions@v20.0.4...v20.0.15

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Testably/Testably.Abstractions).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: released Issues that are released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants