fix: drop mutex guard when DuplexStream I/O op is pending #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
commented
Oct 25, 2024
| // drop the Mutex guard or it could deadlock | ||
| // https://github.com/SteveLauC/monoio-duplex/issues/7 | ||
| drop($guard); | ||
| std::future::pending().await |
There was a problem hiding this comment.
Future polls to this future will always return Pending due to this line, the state of this future has been changed, which should never be done!
SteveLauC
added a commit
to infinilabs/rskafka-monoio
that referenced
this pull request
Oct 28, 2024
### What does this PR do This PR is our first step that changes the runtime used by rskafka from Tokio to Monoio, currently, the following items are done: * source code can be built * unit tests are all passed > The unit tests of `Messenger` have been removed bc they need `tokio::io::DuplexStream`. I tried to port its implementation but failed because Monoio's I/O traits require the implementation of `SimplexStream` to support concurrent read/write[1], `Tokio::io::SimplexStream` is basically a `bytes::BytesMut`, so it cannot support that. > > They can be added back once we have a working version of [monoio-duplex](https://github.com/SteveLauC/monoio-duplex) The things that do not work: 1. TLS support 2. SOCKS5 proxy 3. Integration tests 4. Fuzzy tests 5. Benchmark [1]: `DuplexStream` basically contains 2 `SimplexStream`, one for read, the other for write. If `SimplexStream` does not support concurrent read/write, then it needs to be wrapped in a `Mutex`, then you will have [this issue](SteveLauC/monoio-duplex#7), which is unsolvable, the patch sent in [this PR](SteveLauC/monoio-duplex#8 (comment)) won't work because it changes the state of future, which should never be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Mutex#7, closes DuplexStream pending I/O keeps holding theMutex#7.async_lock::Mutexwithstd::sync::Mutexbecause:Drop, I usedfutures::executor::block_on()before this PR, but it is dangerous and can lead to deadlock with careless mistakes.Mutex#7 won't happen again.