Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This PR is our first step that changes the runtime used by rskafka from Tokio to Monoio, currently, the following items are done:
source code can be built
unit tests are all passed
The things that do not work:
[1]:
DuplexStream
basically contains 2SimplexStream
, one for read, the other for write. IfSimplexStream
does not support concurrent read/write, then it needs to be wrapped in aMutex
, then you will have this issue, which is unsolvable, the patch sent in this PR won't work because it changes the state of future, which should never be done.