Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable table borders by default #3736

Merged
merged 1 commit into from
May 8, 2024

Conversation

10110111
Copy link
Contributor

@10110111 10110111 commented May 8, 2024

This is one more preparation step for the stellarium-skycultures format support, where the tables are normally typeset in Markdown, which then creates plain <table> tags. These tables need the borders, so this patch enables them by default.

If a table is used for laying out content, where the borders would be unwelcome, it should now use class="layout" attribute, while "nomenclature" class is no longer used. This rule is implemented in all the current sky cultures.

If a table is used for laying out content, it should now use
class="layout" attribute, while "nomenclature" class is no longer used.
Copy link

github-actions bot commented May 8, 2024

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update po/stellarium-skycultures/POFILES.in file respectively to changes in sky cultures?
  • Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
  • Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures (see info.ini file)?
  • Did you remember to define license parameter in sky cultures (see info.ini file)?
  • Did you remember to define region parameter in sky culture (see info.ini file)?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added this to the 24.2 milestone May 8, 2024
@10110111 10110111 merged commit c50be3c into Stellarium:master May 8, 2024
15 of 16 checks passed
@10110111 10110111 deleted the table-borders-default branch May 8, 2024 15:52
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label May 13, 2024
Copy link

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Jun 23, 2024
Copy link

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants