[CI] unit testing in FreeBSD and OpenBSD systems

.github/workflows/ci-unix.yml

@@ -0,0 +1,213 @@
+#
+# Implementation of Continuous Integration process for UNIX by Github actions (with extra additionals...)
+#
+name: "CI"
+
+on:
+  push:
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [master]
+
+jobs:
+  ci-freebsd-qt5:
+    name: "FreeBSD (x86_64; qt5)"
+    runs-on: ubuntu-latest
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Build and run unit tests in FreeBSD
+      uses: vmactions/freebsd-vm@v1
+      id: freebsd-qt5
+      with:
+        # Use sh shell
+        usesh: true
+        # When using rsync, you can define copyback: false to not copy files back from the VM in to the host.
+        copyback: false
+        prepare: |
+          pkg install -y cmake eigen glm exiv2 nlopt perl5 xorg-vfbserver gettext qt5-buildtools qt5-charts qt5-concurrent qt5-core qt5-declarative qt5-gui qt5-script qt5-serialport qt5-qmake qt5-webengine qt5-widgets qt5-testlib qt5-linguisttools qt5-location qt5-network qt5-multimedia qt5-opengl qt5-webchannel
+
+        run: |
+          set -e -x
+          export DISPLAY=:0
+          mkdir builds
+          cd builds
+          cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_TESTING=On "${{ github.workspace }}"
+          make -j3
+          Xvfb :0 -ac -screen 0 1024x768x24+32 >/dev/null 2>&1 &
+          sleep 3
+          ctest --output-on-failure
+          sleep 1
+          pkill Xvfb
+
+  ci-freebsd-qt6:
+    name: "FreeBSD (x86_64; qt6)"
+    runs-on: ubuntu-latest
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Build and run unit tests in FreeBSD
+      uses: vmactions/freebsd-vm@v1
+      id: freebsd-qt6
+      with:
+        # Use sh shell
+        usesh: true
+        # When using rsync, you can define copyback: false to not copy files back from the VM in to the host.
+        copyback: false
+        prepare: |
+          pkg install -y cmake eigen glm exiv2 nlopt perl5 xorg-vfbserver gettext qt6-webengine qt6-base qt6-tools qt6-serialport qt6-location qt6-positioning qt6-multimedia qt6-charts
+
+        run: |
+          set -e -x
+          export DISPLAY=:0
+          mkdir builds
+          cd builds
+          cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_TESTING=On "${{ github.workspace }}"
+          make -j3
+          Xvfb :0 -ac -screen 0 1024x768x24+32 >/dev/null 2>&1 &
+          sleep 3
+          ctest --output-on-failure
+          sleep 1
+          pkill Xvfb
+
+  ci-openbsd-qt5:
+    name: "OpenBSD (x86_64; qt5)"
+    runs-on: ubuntu-latest
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Build and run unit tests in OpenBSD
+      uses: vmactions/openbsd-vm@v1
+      id: openbsd-qt5
+      with:
+        # Use sh shell
+        usesh: true
+        # When using rsync, you can define copyback: false to not copy files back from the VM in to the host.
+        copyback: false
+        prepare: |
+          pkg_add -aU cmake eigen3 glm exiv2 nlopt gpsd qt5-qxlsx qt5 gettext-runtime gettext-tools
+
+        run: |
+          set -e -x
+          #export Qt5_DIR=/usr/local/lib/qt5/cmake/Qt5
+          #export Qt5Script_DIR=/usr/local/lib/qt5/cmake/Qt5Script
+          #export Qt5LinguistTools_DIR=/usr/local/lib/qt5/cmake/Qt5LinguistTools
+          export PATH=$PATH:/usr/local/lib/qt5/bin
+          export DISPLAY=:0
+          mkdir builds
+          cd builds
+          cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=/usr/local/lib/qt5/cmake -DENABLE_TESTING=On -DENABLE_QTWEBENGINE=Off "${{ github.workspace }}"
+          make -j3
+          Xvfb :0 -ac -screen 0 1024x768x24+32 >/dev/null 2>&1 &
+          sleep 3
+          ctest --output-on-failure
+          sleep 1
+          pkill Xvfb
+
+  ci-openbsd-qt6:
+    name: "OpenBSD (x86_64; qt6)"
+    runs-on: ubuntu-latest
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Build and run unit tests in OpenBSD
+      uses: vmactions/openbsd-vm@v1
+      id: openbsd-qt6
+      with:
+        # Use sh shell
+        usesh: true
+        # When using rsync, you can define copyback: false to not copy files back from the VM in to the host.
+        copyback: false
+        prepare: |
+          pkg_add -aU cmake eigen3 glm exiv2 nlopt gpsd qt6-qxlsx qt6 gettext-runtime gettext-tools
+
+        run: |
+          set -e -x
+          export DISPLAY=:0
+          mkdir builds
+          cd builds
+          cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_TESTING=On -DENABLE_QTWEBENGINE=Off "${{ github.workspace }}"
+          make -j3
+          Xvfb :0 -ac -screen 0 1024x768x24+32 >/dev/null 2>&1 &
+          sleep 3
+          ctest --output-on-failure
+          sleep 1
+          pkill Xvfb
+
+  ci-dragonflybsd-qt5:
+    name: "DragonflyBSD (x86_64; qt5)"
+    runs-on: ubuntu-latest
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Build and run unit tests in DragonflyBSD
+      uses: vmactions/dragonflybsd-vm@v1
+      id: dragonflybsd-qt5
+      with:
+        # Use sh shell
+        usesh: true
+        # When using rsync, you can define copyback: false to not copy files back from the VM in to the host.
+        copyback: false
+        prepare: |
+          pkg install -y cmake gettext perl5 xorg-vfbserver qt5-buildtools qt5-charts qt5-concurrent qt5-core qt5-declarative qt5-gui qt5-linguisttools qt5-location qt5-multimedia qt5-network qt5-opengl qt5-qmake qt5-script qt5-serialport qt5-testlib qt5-webengine 
+
+        run: |
+          set -e -x
+          export DISPLAY=:0
+          mkdir builds
+          cd builds
+          cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_TESTING=On -DENABLE_SHOWMYSKY=Off -DUSE_PLUGIN_LENSDISTORTIONESTIMATOR=Off "${{ github.workspace }}"
+          make -j3
+          Xvfb :0 -ac -screen 0 1024x768x24+32 >/dev/null 2>&1 &
+          sleep 3
+          ctest --output-on-failure
+          sleep 1
+          pkill Xvfb
+
+  ci-dragonflybsd-qt6:
+    name: "DragonflyBSD (x86_64; qt6)"
+    runs-on: ubuntu-latest
+    if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.actor, 'transifex')"
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Build and run unit tests in DragonflyBSD
+      uses: vmactions/dragonflybsd-vm@v1
+      id: dragonflybsd-qt6
+      with:
+        # Use sh shell
+        usesh: true
+        # When using rsync, you can define copyback: false to not copy files back from the VM in to the host.
+        copyback: false
+        prepare: |
+          pkg install -y cmake perl5 xorg-vfbserver gettext qt6-base qt6-tools qt6-serialport qt6-positioning qt6-multimedia qt6-charts qt6-declarative
+
+        run: |
+          set -e -x
+          export DISPLAY=:0
+          mkdir builds
+          cd builds
+          cmake -DCMAKE_BUILD_TYPE=Debug -DENABLE_TESTING=On -DENABLE_SHOWMYSKY=Off -DUSE_PLUGIN_LENSDISTORTIONESTIMATOR=Off -DENABLE_QTWEBENGINE=Off "${{ github.workspace }}"
+          make -j3
+          Xvfb :0 -ac -screen 0 1024x768x24+32 >/dev/null 2>&1 &
+          sleep 3
+          ctest --output-on-failure
+          sleep 1
+          pkill Xvfb

CMakeLists.txt

@@ -686,8 +686,8 @@ SET(CMAKE_INCLUDE_CURRENT_DIR ON)
 IF(ENABLE_SHOWMYSKY)
     ADD_DEFINITIONS(-DENABLE_SHOWMYSKY)
     CPMFindPackage(NAME ShowMySky-Qt${QT_VERSION_MAJOR}
-		URL https://github.com/10110111/CalcMySky/archive/refs/tags/v0.3.1.tar.gz
-        URL_HASH SHA256=d284eaabcf21ad3d1f520a1d1b1b533f7c5f5a44ba92495dd38e238874e8e4d7
+		URL https://codeload.github.com/10110111/CalcMySky/zip/refs/heads/master
+#        URL_HASH SHA256=d284eaabcf21ad3d1f520a1d1b1b533f7c5f5a44ba92495dd38e238874e8e4d7
         EXCLUDE_FROM_ALL yes
         OPTIONS "QT_VERSION ${QT_VERSION_MAJOR}")
     IF(ShowMySky-Qt${QT_VERSION_MAJOR}_ADDED)

src/StelLogger.cpp

@@ -214,11 +214,7 @@ void StelLogger::init(const QString& logFilePath)
 	dmesg.waitForStarted();
 	dmesg.waitForFinished();
 	const QString dmesgData(dmesg.readAll());
-	#if (QT_VERSION>=QT_VERSION_CHECK(5, 14, 0))
-	QStringList dmesgLines = dmesgData.split('\n', QString::SkipEmptyParts);
-	#else
 	QStringList dmesgLines = dmesgData.split('\n', Qt::SkipEmptyParts);
-	#endif
 	for (int i = 0; i<dmesgLines.size(); i++)
 	{
 		if (dmesgLines.at(i).contains("memory"))

src/core/OctahedronPolygon.cpp

@@ -418,7 +418,7 @@ struct OctTessTrianglesCallbackData
 void errorCallback(GLenum errn)
 {
 	qWarning() << "Tessellator error:" << QString::fromLatin1(reinterpret_cast<const char*>(gluesErrorString(errn)));
-	Q_ASSERT(0);
+	//Q_ASSERT(0);
 }
 
 void vertexTrianglesCallback(Vec3d* vertexData, OctTessTrianglesCallbackData* userData)

src/core/StelLocationMgr.cpp

@@ -1078,19 +1078,21 @@ void StelLocationMgr::changeLocationFromGPSQuery(const StelLocation &locin)
 	const bool verbose=qApp->property("verbose").toBool();
 	StelCore *core=StelApp::getInstance().getCore();
 	StelLocation loc=locin;
+	const float latitude = loc.getLatitude();
+	const float longitude = loc.getLongitude();
 	loc.lightPollutionLuminance=StelLocation::DEFAULT_LIGHT_POLLUTION_LUMINANCE;
 	// Usually you don't leave your time zone with GPS.
 	loc.ianaTimeZone=core->getCurrentTimeZone();
 	loc.isUserLocation=true;
 	loc.planetName="Earth";
 	loc.name=QString("GPS %1%2 %3%4")
-		.arg(loc.getLatitude()<0?"S":"N").arg(qRound(abs(loc.getLatitude())))
-		.arg(loc.getLongitude()<0?"W":"E").arg(qRound(abs(loc.getLongitude())));
+		.arg(latitude<0.f?"S":"N").arg(qRound(qAbs(latitude)))
+		.arg(longitude<0.f?"W":"E").arg(qRound(qAbs(longitude)));
 	LandscapeMgr *lMgr=GETSTELMODULE(LandscapeMgr);
 	QString landscapeAutoName;
 	if (lMgr->getFlagLandscapeAutoSelection())
 	{
-		QColor color=getColorForCoordinates(loc.getLongitude(), loc.getLatitude());
+		QColor color=getColorForCoordinates(longitude, latitude);
 		landscapeAutoName=QString("ZeroColor(%1)").arg(Vec3f(color).toStr());
 	}
 	core->moveObserverTo(loc, 0.0, 0.0, landscapeAutoName);
@@ -1101,7 +1103,7 @@ void StelLocationMgr::changeLocationFromGPSQuery(const StelLocation &locin)
 	}
 	if (verbose)
 	{
-		qDebug() << "Location in progress: Long=" << loc.getLongitude() << " Lat=" << loc.getLatitude() << " Alt" << loc.altitude;
+		qDebug() << "Location in progress: Long=" << longitude << " Lat=" << latitude << " Alt" << loc.altitude;
 		qDebug() << "New location named " << loc.name;
 		qDebug() << "queryOK, resetting GUI";
 	}

src/scripting/V3d.cpp

@@ -42,9 +42,9 @@ V3d & V3d::operator =(const V3d &v)
 QString V3d::toHex() const
 {
 	return QString("#%1%2%3")
-		.arg(qMin(255, int(m_x * 255)), 2, 16, QChar('0'))
-		.arg(qMin(255, int(m_y * 255)), 2, 16, QChar('0'))
-		.arg(qMin(255, int(m_z * 255)), 2, 16, QChar('0'));
+		.arg(qMin(255, qRound(m_x * 255)), 2, 16, QChar('0'))
+		.arg(qMin(255, qRound(m_y * 255)), 2, 16, QChar('0'))
+		.arg(qMin(255, qRound(m_z * 255)), 2, 16, QChar('0'));
 }
 
 /////////////////////
@@ -63,6 +63,14 @@ V3f & V3f::operator =(const V3f &v)
 	return *this;
 }
 
+QString V3f::toHex() const
+{
+	return QString("#%1%2%3")
+		.arg(qMin(255, qRound(m_x * 255)), 2, 16, QChar('0'))
+		.arg(qMin(255, qRound(m_y * 255)), 2, 16, QChar('0'))
+		.arg(qMin(255, qRound(m_z * 255)), 2, 16, QChar('0'));
+}
+
 ///////////////////////
 #ifdef ENABLE_SCRIPT_QML
 
@@ -100,8 +108,8 @@ Color::Color(QString hexColor) : QObject()
 QString Color::toHex() const
 {
 	return QString("#%1%2%3")
-		.arg(qMin(255, int(m_r * 255)), 2, 16, QChar('0'))
-		.arg(qMin(255, int(m_g * 255)), 2, 16, QChar('0'))
-		.arg(qMin(255, int(m_b * 255)), 2, 16, QChar('0'));
+		.arg(qMin(255, qRound(m_r * 255)), 2, 16, QChar('0'))
+		.arg(qMin(255, qRound(m_g * 255)), 2, 16, QChar('0'))
+		.arg(qMin(255, qRound(m_b * 255)), 2, 16, QChar('0'));
 }
 #endif

src/scripting/V3d.hpp

@@ -75,7 +75,7 @@ public slots:
 	//! Formats a comma-separated string in angle brackets
 	//! @todo currently this seems to to nothing. JS print output shows "V3d(address)". Use toVec3d() to show the values formatted by Vec3d's method.
 	Q_INVOKABLE QString toString() const {return QString("[%1, %2, %3]").arg(m_x).arg(m_y).arg(m_z);}
-	//! Formats a hex string
+	//! Formats a hex string usable as HTML color
 	Q_INVOKABLE QString toHex() const;
 private:
 	double m_x, m_y, m_z;
@@ -122,6 +122,8 @@ public slots:
 	//! Formats a comma-separated string in angle brackets
 	//! @todo currently this seems to to nothing. JS print output shows "V3f(address)". Use toVec3f() to show the values formatted by Vec3f's method.
 	Q_INVOKABLE QString toString() const {return QString("[%1, %2, %3]").arg(m_x).arg(m_y).arg(m_z);}
+	//! Formats a hex string usable as HTML color
+	Q_INVOKABLE QString toHex() const;
 private:
 	float m_x, m_y, m_z;
 };