Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] unit testing in FreeBSD and OpenBSD systems #3599

Merged
merged 57 commits into from
Jan 28, 2024
Merged

[CI] unit testing in FreeBSD and OpenBSD systems #3599

merged 57 commits into from
Jan 28, 2024

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Jan 19, 2024

Description

This pull request added support to build and run unit tests in FreeBSD and OpenBSD systems.

Important part of this PR is updated unit tests for JavaScripting (The deep investigation of test fails is needs for FreeBSD/Qt5 CI).

Type of change

  • Housekeeping

Copy link

github-actions bot commented Jan 19, 2024

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@10110111
Copy link
Contributor

Why do you disable ShowMySky here?

@alex-w
Copy link
Member Author

alex-w commented Jan 19, 2024

Why do you disable ShowMySky here?

FreeBSD has binary package for Qt5-based ShowMySky only. At first attempt, building ShowMySky in FreeBSD/Qt6 was failed :(

Let's enable it again and please check the results.

@10110111
Copy link
Contributor

make[2]: make[2]: don't know how to make _deps/showmysky-qt6-build/check. Stop

I guess this is because of the spaces in check version update target. Try using the latest master of CalcMySky, I've pushed a potential fix for this.

@alex-w
Copy link
Member Author

alex-w commented Jan 20, 2024

OK.

NetBSD: no exist binary package of MesaLib for NetBSD 9.x and it's not possible to build it from source code (via pkgsrc) due limitations for VM, so, the critical dependency is missing - no OpenGL, no Stellarium.

DragonflyBSD: Stellarium built without ShowMySky and Lens Distortion Estimator plugin, because binary packages of dependencies for these features is too old. Building from source code is failing (probably GCC 8.4 is too old for it).

@alex-w
Copy link
Member Author

alex-w commented Jan 20, 2024

OK.

Solaris: version 11.4 was released in 2018 and it has too old packages (cmake 3.9), so, I removed this CI

@alex-w
Copy link
Member Author

alex-w commented Jan 28, 2024

@gzotti @10110111 please review the PR

@alex-w alex-w added the infrastructure Infrastructure related issues label Jan 28, 2024
src/scripting/V3d.hpp Outdated Show resolved Hide resolved
src/scripting/V3d.cpp Outdated Show resolved Hide resolved
@gzotti
Copy link
Member

gzotti commented Jan 28, 2024

I wonder how many kWh per commit we are burning... And how much of that is just "install environment" before even compilation... :-o

Copy link
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problems now.

@10110111
Copy link
Contributor

Some builds fail. Is it expected?

@10110111
Copy link
Contributor

Why did you have to edit the tests in this PR?

@alex-w
Copy link
Member Author

alex-w commented Jan 28, 2024

Some builds fail. Is it expected?

it's something wrong in memory with Qt5/QtScript - I didn't checked it in deep

@alex-w
Copy link
Member Author

alex-w commented Jan 28, 2024

Why did you have to edit the tests in this PR?

wrong limits, so, some parts of tests never running before

@alex-w alex-w merged commit bafa5a5 into master Jan 28, 2024
42 of 47 checks passed
@alex-w alex-w deleted the ci/unix branch January 28, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure related issues
Development

Successfully merging this pull request may close these issues.

3 participants