Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Languages Again #893

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Fix Languages Again #893

merged 5 commits into from
Sep 11, 2024

Conversation

Mnemotechnician
Copy link
Contributor

@Mnemotechnician Mnemotechnician commented Sep 9, 2024 •
edited
Loading

Description

4 fixes:

  • Fixed translators stopping to provide a language for a fraction of a tick, causing the provided language to get de-selected when moving a translator within your inventory (from hands to pocket or otherwise)
  • Fixed translators not updating your languages when running out of power (literally forgot to call UpdateEntityLanguages)
  • Fixed language menu breaking after you reconnect to the server (the issue is tricky, apparently all subscriptions made by ui controllers are invalidated when the client switches from gameplay state to menu state (the "you are disconnected" one), but never calls Initialize() for them again, which means they can never re-create the same subscriptions... Which explains why the ahelp menu was breaking for me after reconnecting. All UI controllers that make event subscriptions are affected by this bug)
  • Fixed the language menu button not updating when you close the menu manually.

Changelog

🆑

  • fix: Fixed a couple issues with the language menu UI and translators.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Sep 9, 2024
@SimpleStation14 SimpleStation14 changed the title fix translators again Fix Translators Again Sep 9, 2024
@Mnemotechnician Mnemotechnician changed the title Fix Translators Again Fix Languages Again Sep 10, 2024
@github-actions github-actions bot added the Changes: UI Changes any XAML files label Sep 10, 2024
@Mnemotechnician
Copy link
Contributor Author

Now that I rooted out several more issues, I opted in to fix them as a part of this PR. See the PR body for more details.

Mnemotechnician added a commit to Mnemotechnician/floofstation that referenced this pull request Sep 10, 2024
@Mnemotechnician
Sqash: Simple-Station/Einstein-Engines#893
da91e0b 
FIX THE DAMN LANGUAGE WINDOW

Fix another issue

fix
@Mnemotechnician Mnemotechnician mentioned this pull request Sep 10, 2024
Merged
@Mnemotechnician
Copy link
Contributor Author

Mimic test fails strike again :trollface:

@Evgencheg
Copy link
Contributor

Mimic test fails strike again :trollface:

yep... why this errors - idk

Fansana added a commit to Fansana/floofstation1 that referenced this pull request Sep 10, 2024
@Fansana
Merge pull request #182 from Mnemotechnician/fix/floof-early-merge-la…
34b74bf 
…nguage-fixes

Early-Merge Simple-Station/Einstein-Engines#893
@VMSolidus VMSolidus merged commit 2a59ad3 into Simple-Station:master Sep 11, 2024
12 checks passed
SimpleStation14 added a commit that referenced this pull request Sep 11, 2024
@SimpleStation14
Automatic Changelog Update (#893)
6143cc2
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMSolidus VMSolidus VMSolidus approved these changes

@OldDanceJacket OldDanceJacket OldDanceJacket approved these changes

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: UI Changes any XAML files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mnemotechnician @Evgencheg @VMSolidus @OldDanceJacket