Skip to content

Warn when --only-bootsnap-rbs-cache runs without TAPIOCA_RBS_CACHE=1 #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KaanOzkan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Warn when --only-bootsnap-rbs-cache runs without TAPIOCA_RBS_CACHE=1 #2624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/tapioca/commands/dsl_generate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ def execute
load_application

if @only_bootsnap_rbs_cache
unless ENV["TAPIOCA_RBS_CACHE"] == "1"
say_error("Warning: --only-bootsnap-rbs-cache has no effect without TAPIOCA_RBS_CACHE=1", :yellow)
end
say("Bootsnap RBS cache populated, exiting before RBI generation.", :green)
return
end
Expand Down
24 changes: 22 additions & 2 deletions spec/tapioca/cli/dsl_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,13 +669,33 @@ class Post
end
RB

result = @project.tapioca("dsl --only-bootsnap-rbs-cache Post")
result = @project.tapioca("dsl --only-bootsnap-rbs-cache Post", env: { "TAPIOCA_RBS_CACHE" => "1" })

assert_stdout_includes(result, <<~OUT)
Bootsnap RBS cache populated, exiting before RBI generation.
OUT

assert_empty_stderr(result)
assert_stderr_includes(result, "bootsnap miss:")
refute_project_file_exist("sorbet/rbi/dsl/post.rbi")
assert_success_status(result)
end

it "warns when --only-bootsnap-rbs-cache is set without TAPIOCA_RBS_CACHE=1" do
@project.write!("lib/post.rb", <<~RB)
require "smart_properties"

class Post
include SmartProperties
property :title, accepts: String
end
RB

result = @project.tapioca("dsl --only-bootsnap-rbs-cache Post")

assert_stderr_includes(
result,
"Warning: --only-bootsnap-rbs-cache has no effect without TAPIOCA_RBS_CACHE=1",
)
refute_project_file_exist("sorbet/rbi/dsl/post.rbi")
assert_success_status(result)
end
Expand Down
Loading