Warn when --only-bootsnap-rbs-cache runs without TAPIOCA_RBS_CACHE=1#2624
Open
KaanOzkan wants to merge 1 commit into
Open
Warn when --only-bootsnap-rbs-cache runs without TAPIOCA_RBS_CACHE=1#2624KaanOzkan wants to merge 1 commit into
--only-bootsnap-rbs-cache runs without TAPIOCA_RBS_CACHE=1#2624KaanOzkan wants to merge 1 commit into
Conversation
Without the env var set, `bootsnap/setup` isn't required at boot and no RBS cache gets populated. Previously the command would still print "Bootsnap RBS cache populated", misleading users into thinking it had done useful work. Addresses #2617 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TAPIOCA_RBS_CACHE=1set,bootsnap/setupisn't required at boot and no RBS cache gets populated. Previouslytapioca dsl --only-bootsnap-rbs-cachewould still print "Bootsnap RBS cache populated", misleading users into thinking it had done useful work.Test plan
warns when --only-bootsnap-rbs-cache is set without TAPIOCA_RBS_CACHE=1TAPIOCA_RBS_CACHE=1and assert bootsnap stats appear on stderr (confirming bootsnap actually ran)