Skip to content

Extract sorbet_syntax_check!#2572

Merged
amomchilov merged 1 commit intomainfrom
Alex/extract-sorbet_syntax_check-helper
Apr 1, 2026
Merged

Extract sorbet_syntax_check!#2572
amomchilov merged 1 commit intomainfrom
Alex/extract-sorbet_syntax_check-helper

Conversation

@amomchilov
Copy link
Copy Markdown
Contributor

@amomchilov amomchilov commented Apr 1, 2026

Motivation

There's a small bug in Prism+Sorbet that requires me to pick between --stop-after=parser and --stop-after=desugar (PR for fix). It's easy enough to workaround, but needs access to some Sorbet config, which is nicer to keep contained within this SorbetHelper.

You can see the usage up-stack in #2567

Along the way, I also discovered the --e-rbi Sorbet flag, which is more fitting for this usage. In principle, it would allow us to have multiple overloads in the RBI, though that isn't something that's used by any DSL compilers today.

Implementation

See the diff I guess

Tests

Passes existing tests.

Using Sorbet's more-specific RBI mode.
@amomchilov
Copy link
Copy Markdown
Contributor Author

amomchilov commented Apr 1, 2026

@amomchilov amomchilov added the refactor Code refactor with no behaviour change label Apr 1, 2026
@amomchilov amomchilov marked this pull request as ready for review April 1, 2026 18:20
@amomchilov amomchilov requested a review from a team as a code owner April 1, 2026 18:20
@amomchilov amomchilov merged commit 6210b4c into main Apr 1, 2026
17 of 21 checks passed
@amomchilov amomchilov deleted the Alex/extract-sorbet_syntax_check-helper branch April 1, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore refactor Code refactor with no behaviour change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants