Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
502c337 to
9c3e29b
Compare
Morriar
reviewed
Apr 1, 2026
| key = key #: as !nil | ||
|
|
||
| [key, value] | ||
| end.to_h #: Hash[String, String | bool | nil] |
Contributor
Author
There was a problem hiding this comment.
Ah that's up-stack in https://app.graphite.com/github/pr/Shopify/tapioca/2569
I moved it.
9c3e29b to
0189305
Compare
amomchilov
commented
Apr 1, 2026
|
|
||
| # Represents the `sorbet/config` file, and provides access to its options. https://sorbet.org/docs/cli-ref | ||
| # If the file doesn't exist, this object will still exist, but will return default values for all options. | ||
| class SorbetConfig |
Contributor
Author
There was a problem hiding this comment.
Oh wow, Claude just spit this out so easily, didn't even realize this already exists: https://github.com/Shopify/spoom/blob/main/lib/spoom/sorbet/config.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
We should use the Prism mode in repos that have it enabled in Sorbet (with
--parse=prismin theirsorbet/config),Implementation
Added a simple little
SorbetConfigclass which parses the config file, and exposes nicer APIs for reading its various values.What's the right place to put this? Perhaps in Spoom?
Performance
Shaves off ~1.5 seconds (5%) on the Shopify core monolith.
Tests
Added.