-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mount_matrix): Update gyro matrices #220
Conversation
1cd8eb6
to
5682527
Compare
Per discussion with @pastaq, this is a step towards bringing InputPlumber's gyro output in line with that of Steam Deck. Thanks to: |
I'll test this on some of the remaining devices this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test the following devices:
AYANEO 2021
AYANEO 2
AYANEO AIR
AYANEO AIR Plus
AYN Loki Max
I tried to test the AYANEO Next Lite but it was behaving very strangely and I wasn't able to get a valid test out of it. Similarly I need to reinstall the OS on my OrangePi Neo as its currently stuck on a broken version. I'll be unavailable for about 2 weeks if anyone else wants to provide feedback for the remaining devices.
I'd like to double check again that the axes in your last comment are correct for positive/negative values. The animations feel backwards for the first and second axes when the correct matrix is applies to render positive/negative values as described in it.
This isn't the best example, but I think it can help if reviewed at 0.5x speed: This video at the marked timestamp shows which rotations on the Steam Deck produce positive or negative deflection values for the first two axes. I struggle to find an accurate and well-communicated method of describing these rotations other than the image provided in the previous comment, but I would definitely welcome any other descriptions. If your corrections correlate to the rotations and deflection values shown in the video, then they are correct. |
Okay, seems we're on the same page then. I'll finish testing the remaining devices later this month. Thanks. |
I should have some time this weekend to verify on the following devices: That should cover the majority of devices people are using. It would be nice to get an Loki Zero and Loki Mini Pro, air plus mendo before this is merged. I'm comfortable with the win4, air 1s as they are tested on at leas t one CPU. Claw I'm not worries about as that hasn't been confirmed working yet anyway. |
No idea if I'll be able to get access to any of those, but I'll update if someone with one turns up. |
Per discussion with @pastaq
Update mount_matrix to match Steam Deck gyroscope output, per discussion with @pastaq Thanks to: @dansl and @cuongnphan for providing gyro data on Air 1S 7840U @aarron-lee for providing gyro data and testing on Win 4 6800U .bastardgoose on Discord for providing gyro data and testing on Ally X @fewtarius for providing gyro data on Loki Max and gyro data and testing on 2S on Flip KB @pastaq for providing gyro testing on Air, 2021 and Loki Max @winghugs for providing gyro testing on Air 1S 8840U Co-Authored-By: Dan Long <[email protected]> Co-Authored-By: cuongnphan <[email protected]> Co-Authored-By: Aarron Lee <[email protected]> Co-Authored-By: fewtarius <[email protected]> Co-Authored-By: Derek J. Clark <[email protected]> Co-Authored-By: Kin <[email protected]>
We spent some time today on the Flip KB and 2S to make sure they behave correctly. :) |
Tested successfully on Flip DS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is well baked. Any issues can be solved in a bug fix.
Resolves #217 |
🎉 This PR is included in version 0.40.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
WIP. Still gathering device data.