feat: set up session in onRequest rather than preValidation
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @SerayaEryn. When you will be able to merge this PR and make a release? This deprecation warning is really annoying :( |
|
@SerayaEryn any news on this? |
|
Should we fork this plugin? Looks like the author have no interest any more |
|
@SerayaEryn We do need this, also if you don't want to maintain it anymore maybe can you promote a maintainer or transfer ownership? |
|
Guys someone have forked this repo with all up to date? |
|
See that alternative #137 (comment) |
|
We published the github repo and made it available on npm: https://github.com/fastify/session . @SimenB could you please port this PR to the new repo? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to access the session data in any
onRequesthook is useful (in my case needed since we still usefastify-expresswhich only runs in that hook).Also fixes deprecation warnings, see #137, #138 and #143 since this introduced usage of
onRequestin the first place