fix: don't use decorateRequest with reference types #138
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see FastifyDeprecation [FSTDEP006]
|
@SerayaEryn can we merge this? (: |
chill-cod3r
reviewed
Jan 15, 2021
| fastify.decorateRequest('destroySession', destroySession) | ||
| fastify.addHook('preValidation', preValidation(options)) | ||
| fastify.addHook('onSend', onSend(options)) | ||
| fastify.addHook('onRequest', (req, reply, next) => { | ||
| req.sessionStore = options.store | ||
| req.session = {} |
There was a problem hiding this comment.
minor but I think this line is not necessary since it always gets assigned to either a new session or an existing one by the preValidation hook right? (I could have missed something, if so feel free to ignore this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137
Also see:
fastify/fastify#2688
fastify/fastify#2598