Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve demo playback slider #1118

Merged
merged 33 commits into from
Jan 23, 2025
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
476629a
Add volume tracker
defagos Jan 16, 2025
eb5e369
Add slider creation helpers
defagos Jan 16, 2025
11b7f63
Document public APIs
defagos Jan 17, 2025
63c31c0
Extract generic modern slider
defagos Jan 17, 2025
2becd67
Remove unused slider
defagos Jan 17, 2025
0c10048
Fix linting issues
defagos Jan 17, 2025
953f38d
Add TODO
defagos Jan 17, 2025
ab89fc4
Improve implementation
defagos Jan 17, 2025
c261e6d
Introduce custom horizontal slider
defagos Jan 17, 2025
a430505
Center content
defagos Jan 17, 2025
9b3c4c9
Use HSlider in custom layout
defagos Jan 17, 2025
c422243
Display buffer
defagos Jan 17, 2025
3a60286
Extract slider layers
defagos Jan 17, 2025
32eb917
Remove unused code
defagos Jan 17, 2025
0fefe4a
Restore accessibility
defagos Jan 17, 2025
799acf4
Improve API to support optional custom listeners
defagos Jan 17, 2025
bba6786
Remove superfluous annotations
defagos Jan 17, 2025
e0655d3
Provides HStack as player component
defagos Jan 17, 2025
706de52
Fix progress in non-standard ranges
defagos Jan 17, 2025
d607f4c
Fix URL
defagos Jan 17, 2025
c3af9b9
Introduce value to progress conversion methods
defagos Jan 17, 2025
a03ebbb
Display rough volume slider
defagos Jan 17, 2025
ad0c876
Update the volume button image
waliid Jan 17, 2025
454750b
Animate the volume slider
waliid Jan 17, 2025
c2d3e9c
Avoid invalid frame dimension (negative or non-finite)
waliid Jan 17, 2025
6033f50
Reduce spacing
waliid Jan 17, 2025
d40db88
Try to be as close as possible to Apple behavior
waliid Jan 17, 2025
9d7bfce
Improve volume slider implementation
waliid Jan 22, 2025
29ee5c7
Remove volume tracker
waliid Jan 22, 2025
2d0d1f8
Keep HSlider in the demo
waliid Jan 23, 2025
e99fed0
Remove useless view builders
waliid Jan 23, 2025
cebabb9
Disable swiftlint file_length
waliid Jan 23, 2025
e4266ab
Fix tvOS build
waliid Jan 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add TODO
defagos authored and waliid committed Jan 22, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 953f38d9d67737ff83727811d5e5d61c31ba8114
1 change: 1 addition & 0 deletions Demo/Sources/Views/ModernSlider~ios.swift
Original file line number Diff line number Diff line change
@@ -50,6 +50,7 @@ struct ModernSlider<V, ValueLabel>: View where V: BinaryFloatingPoint, V.Stride:
value: $value,
in: bounds,
label: {
// TODO: Should be customizable
Text("Progress")
},
minimumValueLabel: minimumValueLabel,