Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve demo playback slider #1118

Merged
merged 33 commits into from
Jan 23, 2025
Merged

Improve demo playback slider #1118

merged 33 commits into from
Jan 23, 2025

Conversation

waliid
Copy link
Member

@waliid waliid commented Jan 20, 2025 •
edited
Loading

Description

This PR initially introduced to manage the system volume via a volume tracker. However, as mentioned in this comment we had to roll back this feature.
We decided to keep the HSlider component introduced to share the logic between the playback slider and the volume slider.

Changes made

  • Added a volume tracker to manage the system volume.
  • Added HSlider.
  • Remove useless @ViewBuilder

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@waliid waliid linked an issue Jan 20, 2025 that may be closed by this pull request
Volume tracker #1116
Closed
3 tasks
defagos and others added 27 commits January 22, 2025 08:58
@defagos @waliid
Add volume tracker
476629a
@defagos @waliid
Add slider creation helpers
eb5e369
@defagos @waliid
Document public APIs
11b7f63
@defagos @waliid
Extract generic modern slider
63c31c0
@defagos @waliid
Remove unused slider
2becd67
@defagos @waliid
Fix linting issues
0c10048
@defagos @waliid
Add TODO
953f38d
@defagos @waliid
Improve implementation
ab89fc4
@defagos @waliid
Introduce custom horizontal slider
c261e6d
@defagos @waliid
Center content
a430505
@defagos @waliid
Use HSlider in custom layout
9b3c4c9
@defagos @waliid
Display buffer
c422243
@defagos @waliid
Extract slider layers
3a60286
@defagos @waliid
Remove unused code
32eb917
@defagos @waliid
Restore accessibility
0fefe4a
@defagos @waliid
Improve API to support optional custom listeners
799acf4
@defagos @waliid
Remove superfluous annotations
bba6786
@defagos @waliid
Provides HStack as player component
e0655d3
@defagos @waliid
Fix progress in non-standard ranges
706de52
@defagos @waliid
Fix URL
d607f4c
@defagos @waliid
Introduce value to progress conversion methods
c3af9b9
@defagos @waliid
Display rough volume slider
a03ebbb
@waliid
Update the volume button image
ad0c876
@waliid
Animate the volume slider
454750b
@waliid
Avoid invalid frame dimension (negative or non-finite)
c2d3e9c
@waliid
Reduce spacing
6033f50
@waliid
Try to be as close as possible to Apple behavior
d40db88
@waliid waliid force-pushed the 1116-volume-tracker branch from 4b3f88c to d40db88 Compare January 22, 2025 12:54
@waliid waliid changed the title Add a volume tracker to manage the system volume Improve demo playback slider Jan 23, 2025
@waliid waliid marked this pull request as ready for review January 23, 2025 13:04
@waliid waliid enabled auto-merge January 23, 2025 13:05
@waliid waliid added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit f8d1094 Jan 23, 2025
7 checks passed
@waliid waliid deleted the 1116-volume-tracker branch January 23, 2025 13:27
@defagos defagos mentioned this pull request Feb 4, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defagos defagos defagos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Pillarbox
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Volume tracker
2 participants
@waliid @defagos