-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
New quirk: Blessed Blood #714
base: master
Are you sure you want to change the base?
Conversation
This adds the new positive quirk Blessed Blood, which assigns the user trait TRAIT_HOLY. It synergizes with quirk Spiritual, job Chaplain, and quirk Flutter to add more effects. In addition, this introduces quirk incompatibilities and species blacklists where necessary. Any species or quirk that could be considered 'unholy' is marked as incompatible.
- Adds a dynamic ending to the grant message - Adds a point for using Pacifist quirk - Removes the point for using Flutter quirk - Reduces halo point cost to 0 - Moves cosmetic wings to point cost 1 - Renames winged from HOLY_LEVEL_WINGS to HOLY_LEVEL_FLIGHT
do you know what |
It's currently only used in the anti-magic check. This means immunity to wizards, bloodfledges, mind reading, telepathy, and various other anomalous effects. However, the holder is also unable to use almost any magic abilities themselves. On a server with no magic antagonists, the balance concern is minimal. |
maybe i have bad memory, but chaplain have one magic book with smoke spell, no? |
Yes, they do. Holy is not checked by default in the anti-magic check, and shouldn't prevent use of it. |
Now I'm going to preface this by saying that what is and is not merged is ultimately up to Mosley, however, I am assistant headmin, so I figured I might as well go ahead and mention this- It would, most likely, be preferable if the quirk did not blacklist a bunch of other quirks; specifically the more character design-oriented ones, such as dullahan, gargoyle, etcetera. I could see plenty of situations in which someone would want to create a character combining both of those quirks, and the quirks themselves do not... necessarily determine the RACE of the character, it just makes them have that sort of trait, per se. Put simply, just because someone has the dullahan quirk does not mean their character is supposed to be unholy, it just means that they wanted to roleplay a character with a separate head. |
Blocking any race or trait that could be considered blasphemous, monstrous, or cursed is an intended aspect of this quirk's gimmick. As for why they're blocked
Update: Due to a rendering bug: Dullahan overrides the halo and aura effects. |
I understand what you are getting at, however, just because someone has the succubus trait doesn't mean their character is literally a succubus; it is just the trait that lets you get nutrition from cum, plenty of people use it for non-succubus characters, hence the issue. Again, quirks do not determine a character's race, and many quirks are called what they are called simply because there is no better summary of what they do (I.e, what are you going to call the gargoyle quirk other than, well, 'gargoyle'? You could call it the petrification quirk, I suppose, but you get the idea~!) |
This commit makes the following changes - Added comments for quirk blacklist reasoning - Added TRAIT_BLESSED_GLOWING for integration use - Added integration with quirk Gargoyle - - Transforming creates a gilded statue - - Gilded statue will glow with TRAIT_BLESSED_GLOWING
Since gargoyles can be interpreted as 'holy protectors', the quirk will now cause them to become golden statues. If the quirk caused a user to glow, their statue will also glow. |
Whitelists the quirks Incubus and Succubus for use with the Blessed Blood quirk.
This commit focuses on adding penalties for Blessed Blood quirk users that interact with lavaland sin ruin items or structures. At minimum; Users will lose the quirk. At maximum; A strong thematic penalty is applied to the user. Change list: - Adds penalties for the sin ruins - Adds quirk blacklist for Overweight
I too agree that honestly any quirks that don't strictly cause bugs when put together with blessed blood should be allowed to be paired with it. Having their characters follow the "requirements" for being actually considered holy is a flavor option that they should decide to follow on their own, not one that the quirk should enforce upon them |
This commit makes the following changes - Removes Blessed Blood quirk blacklist for Masochism, Overweight, and Werewolf - Removes unused lines - Updates comments
Parses the files changed by the quirk Blessed Blood with the editorconfig settings. This removes trailing whitespaces.
Adds an emissive overlay for the Blessed Blood quirk's halo mob overlay.
Due to an issue with emissive layer rendering on resized character sprites, this commit disables emissive halo rendering.
Adds one holy point for selecting the friendly quirk and empath quirk at the same time. Also reformats holy points to use `variable++` instead of `variable += 1`.
This commit adds Light Sensitivity and Nyctophobia to the Blessed Blood quirk incompatibility list due to potential mechanical conflicts with the quirk's glow effect.
This commit makes makes changes to Holy Water for Blessed Blood quirk users. For the purposes of this commit; High Level and Low Level refer to the quirk holder's amount of holy points. The following changes are made to Holy Water: - Adds on-drink messages based on holy level - Adds thirst reduction effect - Adds stamina regain effect to high level use - Adds mood bonus to high level use - Reduces bonus for low level use - Cancels all other reagent effects for high level use
Updates the Blessed Blood quirk to use the deity name configured in character settings.
Maybe allow those with enough holiness to bless water into holy water? Seems thematically appropriate. |
This commit makes the following changes to Blessed Blood - Adds a quirk removal message - Updates quirk gain messages - Updates sin greed message
This is thematically appropriate, and a good suggestion. This quirk has been successfully tested with the addition of |
wish the cursed blood had more fancy effects |
If designed as a progression quirk like Blessed Blood; Cursed Blood would reward a user for selecting negative quirks and having poor sanity by giving them demonic abilities. |
Id say it would be easy to rebuild the cursed blood quirk to allow it to do so |
Adds a new touch spell Blessed Touch. Obtained by starting a shift with maximum holy level while using Blessed Blood. Icons used are based on the Nuclear Fist spell.
This commit changes the Blessed Touch spell to use admin healing effects.
This commit add a prayer system for Blessed Blood quirk users to request blessings. The following changes are made: - Added the Divine Prayer Altar - Added CSS class blessedphrase - Added CSS animation blessedcolor - Added span define span_blessedphrase - Added admin topic for blessed requests - Removed Blessed Blood rewards for holy points of 3+
some suggestions for this as this kinda reminds me of cult mechanics... like when they get glowing eyes at some stages. maybe that blessed blood stuff could even be made that it dynamically shifts between "demonic" and "holy. so how to "do holy/unholy" things... maybe we got some things related to the 7 sins/virtues... well something for each side: no idea how "balanced" them things should be... i.e. if sacreficeing diamonds or silver or gold from mining could be farmed quickly maybe? or with the 2000cr could be from your job wage... but then again you can steal ro get it from others or from bitcoin machines?... shrugs maybe your "holy/unholy level" could also be added to the scars system and be persistent over rounds for that character. maybe in a way this could even replace the "cult" mechanics and depending on how many "holy/unholy" characters are on the station the station is "blessed or corrupted" i guess doing these +/- things inside the chapel could give double the holy/corruption points then. and in a way them two sides "fight eachother" on the station (not open and harmful, more through influenceing/blessing/corrupting others) to change the "holy/unholy balance of the station" (maybe gives a tiny buff to the "stronger side"?) and maybe the cult runes could be adopted... so holy alinged people can draw holy runes and demons can paint corruption runes... maybe they have to "convert/bless/corrupt" people ontop of them runes similar to converting works for cults. |
This is a great suggestion with many practical ideas in it, but will be quite complicated to implement. The concepts of persistent cross-round holy points, separate holy and demon points (New Vegas reputation style), and evolving by performing actions instead of picking quirks could lead to interesting results. |
Oh, that's quite interesting. I look forward to the merging of this PR. |
About The Pull Request
This adds the new positive quirk Blessed Blood, which assigns the user trait TRAIT_HOLY and grants a cosmetic halo. It synergizes with quirk Spiritual, quirk Pacifist, quirk Friendly, quirk Empath, and job Chaplain to add more unique effects.
Depending on the synergy level; The quirk holder can a halo, cosmetic wings, light emitting aura, and functional wings. Holy water becomes nutritious and quenching, and has it's negative effects removed with high enough holy points. Gaining all effects requires picking multiple other quirks.
Quirk holders that interact with lavaland structures or items will be given a one-time penalty based on their holy level. At minimum; Users will lose the quirk. At maximum; A strong thematic penalty is applied to the user based on the sin type.
Sin penalties are the following:
Halo sprite used is derived from the Blood Cult halo sprite.
When combined with the Gargoyle quirk, the created statue becomes gold, and will copy the quirk holder's glow if possible.
Why It's Good For The Game
Allows creating characters with a strong holy/angelic aesthetic, which acts as a counter to the considerable presence of unholy/demonic characters. Also serves as a method for customizing some compatible quirks.
A Port?
No.
Pre-Merge Checklist
Changelog
馃啈
add: Added new positive quirk: Blessed Blood
tweak: Gargoyles with Blessed Blood will become golden
/:cl: