Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New quirk: Blessed Blood #714

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

LeDrascol
Copy link

@LeDrascol LeDrascol commented Jan 24, 2023

About The Pull Request

This adds the new positive quirk Blessed Blood, which assigns the user trait TRAIT_HOLY and grants a cosmetic halo. It synergizes with quirk Spiritual, quirk Pacifist, quirk Friendly, quirk Empath, and job Chaplain to add more unique effects.

Depending on the synergy level; The quirk holder can a halo, cosmetic wings, light emitting aura, and functional wings. Holy water becomes nutritious and quenching, and has it's negative effects removed with high enough holy points. Gaining all effects requires picking multiple other quirks.

Quirk holders that interact with lavaland structures or items will be given a one-time penalty based on their holy level. At minimum; Users will lose the quirk. At maximum; A strong thematic penalty is applied to the user based on the sin type.

Sin penalties are the following:

  • Greed's slot machine: Transfers all money to cargo, then deletes the holder's bank account.
  • Gluttony's wall: Prevents the holder from tasting or digesting food.
  • Envy's knife: Adds reagent Bone Hurting Juice to the holder. Pending a better effect.

holy_lizard golden_gargoyle

Halo sprite used is derived from the Blood Cult halo sprite.
When combined with the Gargoyle quirk, the created statue becomes gold, and will copy the quirk holder's glow if possible.

Why It's Good For The Game

Allows creating characters with a strong holy/angelic aesthetic, which acts as a counter to the considerable presence of unholy/demonic characters. Also serves as a method for customizing some compatible quirks.

A Port?

No.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

馃啈
add: Added new positive quirk: Blessed Blood
tweak: Gargoyles with Blessed Blood will become golden
/:cl:

This adds the new positive quirk Blessed Blood, which assigns the user trait TRAIT_HOLY. It synergizes with quirk Spiritual, job Chaplain, and quirk Flutter to add more effects.

In addition, this introduces quirk incompatibilities and species blacklists where necessary. Any species or quirk that could be considered 'unholy' is marked as incompatible.
@LeDrascol LeDrascol changed the title Adds the Blessed Blood quirk New quirk: Blessed Blood Jan 24, 2023
@LeDrascol LeDrascol marked this pull request as ready for review January 24, 2023 20:08
- Adds a dynamic ending to the grant message
- Adds a point for using Pacifist quirk
- Removes the point for using Flutter quirk
- Reduces halo point cost to 0
- Moves cosmetic wings to point cost 1
- Renames winged from HOLY_LEVEL_WINGS to HOLY_LEVEL_FLIGHT
@zeroisthebiggay
Copy link

do you know what TRAIT_HOLY does because i initially thought it was TRAIT_ANTIMAGIC but digging shows that cloth golems have it?? and holy water gives you it???? what's it even fucking do????

@LeDrascol
Copy link
Author

do you know what TRAIT_HOLY does [...]

It's currently only used in the anti-magic check. This means immunity to wizards, bloodfledges, mind reading, telepathy, and various other anomalous effects. However, the holder is also unable to use almost any magic abilities themselves. On a server with no magic antagonists, the balance concern is minimal.

@FelixRuin
Copy link

do you know what TRAIT_HOLY does [...]

It's currently only used in the anti-magic check. This means immunity to wizards, bloodfledges, mind reading, telepathy, and various other anomalous effects. However, the holder is also unable to use almost any magic abilities themselves. On a server with no magic antagonists, the balance concern is minimal.

maybe i have bad memory, but chaplain have one magic book with smoke spell, no?

@LeDrascol
Copy link
Author

maybe i have bad memory, but chaplain have one magic book with smoke spell, no?

Yes, they do. Holy is not checked by default in the anti-magic check, and shouldn't prevent use of it.

@LunarFleet
Copy link

Now I'm going to preface this by saying that what is and is not merged is ultimately up to Mosley, however, I am assistant headmin, so I figured I might as well go ahead and mention this-

It would, most likely, be preferable if the quirk did not blacklist a bunch of other quirks; specifically the more character design-oriented ones, such as dullahan, gargoyle, etcetera. I could see plenty of situations in which someone would want to create a character combining both of those quirks, and the quirks themselves do not... necessarily determine the RACE of the character, it just makes them have that sort of trait, per se. Put simply, just because someone has the dullahan quirk does not mean their character is supposed to be unholy, it just means that they wanted to roleplay a character with a separate head.

@LeDrascol
Copy link
Author

LeDrascol commented Jan 27, 2023

It would, most likely, be preferable if the quirk did not blacklist a bunch of other quirks; specifically the more character design-oriented ones, such as dullahan, gargoyle, etcetera.

Blocking any race or trait that could be considered blasphemous, monstrous, or cursed is an intended aspect of this quirk's gimmick. Depending on how literally we interpret the quirks, Dullahan may be acceptable.

As for why they're blocked

  • Cursed Blood: The antithesis of blessed blood. Holy water will hurt you.
  • Incubus and Succubus: These are both defined as "an evil spirit".
  • Bloodsucker Fledgling (Vampire): Vampires are traditionally harmed by anything holy.
  • Werewolf: These are most often depicted as evil creatures harmed by holy sources, even if they're not yet coded this way in SS13.
  • Gargoyle: These are overwhelmingly depicted as malevolent monsters or curse bearers.
  • Masochism: Being, quote, "subjected to physical pain or humiliation" is decidedly unholy.
  • Dullahan: If taken literally; These creatures are most often depicted as a form of demon or mischievous fae. However, we may also interpret this to mean a modular - and possibly cybernetic enhanced - body.

Update: Due to a rendering bug: Dullahan overrides the halo and aura effects.

headless_holy_bug

@LunarFleet
Copy link

It would, most likely, be preferable if the quirk did not blacklist a bunch of other quirks; specifically the more character design-oriented ones, such as dullahan, gargoyle, etcetera.

Blocking any race or trait that could be considered blasphemous, monstrous, or cursed is an intended aspect of this quirk's gimmick. Depending on how literally we interpret the quirks, Dullahan may be acceptable.

As for why they're blocked

  • Cursed Blood: The antithesis of blessed blood. Holy water will hurt you.
  • Incubus and Succubus: These are both defined as "an evil spirit".
  • Bloodsucker Fledgling (Vampire): Vampires are traditionally harmed by anything holy.
  • Werewolf: These are most often depicted as evil creatures harmed by holy sources, even if they're not yet coded this way in SS13.
  • Gargoyle: These are overwhelmingly depicted as malevolent monsters or curse bearers.
  • Masochism: Being, quote, "subjected to physical pain or humiliation" is decidedly unholy.
  • Dullahan: If taken literally; These creatures are most often depicted as a form of demon or mischievous fae. However, we may also interpret this to mean a modular - and possibly cybernetic enhanced - body.

Update: Due to a rendering bug: Dullahan overrides the halo and aura effects.

headless_holy_bug

I understand what you are getting at, however, just because someone has the succubus trait doesn't mean their character is literally a succubus; it is just the trait that lets you get nutrition from cum, plenty of people use it for non-succubus characters, hence the issue. Again, quirks do not determine a character's race, and many quirks are called what they are called simply because there is no better summary of what they do (I.e, what are you going to call the gargoyle quirk other than, well, 'gargoyle'? You could call it the petrification quirk, I suppose, but you get the idea~!)

This commit makes the following changes
- Added comments for quirk blacklist reasoning
- Added TRAIT_BLESSED_GLOWING for integration use
- Added integration with quirk Gargoyle
- - Transforming creates a gilded statue
- - Gilded statue will glow with TRAIT_BLESSED_GLOWING
@LeDrascol
Copy link
Author

(I.e, what are you going to call the gargoyle quirk other than, well, 'gargoyle'? You could call it the petrification quirk, I suppose, but you get the idea~!)

Since gargoyles can be interpreted as 'holy protectors', the quirk will now cause them to become golden statues. If the quirk caused a user to glow, their statue will also glow.

golden_gargoyle

Whitelists the quirks Incubus and Succubus for use with the Blessed Blood quirk.
This commit focuses on adding penalties for Blessed Blood quirk users that interact with lavaland sin ruin items or structures. At minimum; Users will lose the quirk. At maximum; A strong thematic penalty is applied to the user.

Change list:
- Adds penalties for the sin ruins
- Adds quirk blacklist for Overweight
@BongaTheProto
Copy link

I too agree that honestly any quirks that don't strictly cause bugs when put together with blessed blood should be allowed to be paired with it. Having their characters follow the "requirements" for being actually considered holy is a flavor option that they should decide to follow on their own, not one that the quirk should enforce upon them

@LeDrascol LeDrascol marked this pull request as draft January 29, 2023 16:10
This commit makes the following changes
- Removes Blessed Blood quirk blacklist for Masochism, Overweight, and Werewolf
- Removes unused lines
- Updates comments
Parses the files changed by the quirk Blessed Blood with the editorconfig settings. This removes trailing whitespaces.
Adds an emissive overlay for the Blessed Blood quirk's halo mob overlay.
Due to an issue with emissive layer rendering on resized character sprites, this commit disables emissive halo rendering.
Adds one holy point for selecting the friendly quirk and empath quirk at the same time. Also reformats holy points to use `variable++` instead of `variable += 1`.
This commit adds Light Sensitivity and Nyctophobia to the Blessed Blood quirk incompatibility list due to potential mechanical conflicts with the quirk's glow effect.
This commit makes makes changes to Holy Water for Blessed Blood quirk users. For the purposes of this commit; High Level and Low Level refer to the quirk holder's amount of holy points.

The following changes are made to Holy Water:
- Adds on-drink messages based on holy level
- Adds thirst reduction effect
- Adds stamina regain effect to high level use
- Adds mood bonus to high level use
- Reduces bonus for low level use
- Cancels all other reagent effects for high level use
Updates the Blessed Blood quirk to use the deity name configured in character settings.
@Zattarra
Copy link

Zattarra commented Feb 5, 2023

Maybe allow those with enough holiness to bless water into holy water? Seems thematically appropriate.

This commit makes the following changes to Blessed Blood
- Adds a quirk removal message
- Updates quirk gain messages
- Updates sin greed message
@LeDrascol
Copy link
Author

Maybe allow those with enough holiness to bless water into holy water? Seems thematically appropriate.

This is thematically appropriate, and a good suggestion.

This quirk has been successfully tested with the addition of isholy, which allowed using bibles and creating holy water, but determined to detract too much from the chaplain's - already undermined - role on the station.

@lolman65
Copy link

lolman65 commented Feb 5, 2023

wish the cursed blood had more fancy effects

@LeDrascol
Copy link
Author

wish the cursed blood had more fancy effects

If designed as a progression quirk like Blessed Blood; Cursed Blood would reward a user for selecting negative quirks and having poor sanity by giving them demonic abilities.

@lolman65
Copy link

lolman65 commented Feb 6, 2023

wish the cursed blood had more fancy effects

If designed as a progression quirk like Blessed Blood; Cursed Blood would reward a user for selecting negative quirks and having poor sanity by giving them demonic abilities.

Id say it would be easy to rebuild the cursed blood quirk to allow it to do so

Adds a new touch spell Blessed Touch. Obtained by starting a shift with maximum holy level while using Blessed Blood. Icons used are based on the Nuclear Fist spell.
This commit changes the Blessed Touch spell to use admin healing effects.
This commit add a prayer system for Blessed Blood quirk users to request blessings.

The following changes are made:
- Added the Divine Prayer Altar
- Added CSS class blessedphrase
- Added CSS animation blessedcolor
- Added span define span_blessedphrase
- Added admin topic for blessed requests
- Removed Blessed Blood rewards for holy points of 3+
@Neliahawk
Copy link

Neliahawk commented Mar 6, 2023

some suggestions for this as this kinda reminds me of cult mechanics... like when they get glowing eyes at some stages.

maybe that blessed blood stuff could even be made that it dynamically shifts between "demonic" and "holy.
like you start at level 0 and if you do sinfull things you get - points (unholy points) and at some - points your eyes start to glow red... and later on you might get demon horns and bat wings... more demonic things over time.
and if you do holy things you get + points (holy points) and at some positive number you get a halo, aura and wings later on or maybe can revive when dead.
maybe things like "fallen angel/redeemed demon" could work too then. if you get high into "holy" and then sin and get into negative. and first you get "holy bodyparts" and instead of getting demonic parts you corrupt and the holy things get corrupted i.e. your white wings become black or your halo breaks.
and if you first go hard into demonic you get horns and bat wings and if you then redeem yourself your bat wings turn white (?works better with holy getting corrupted and white wings going black than demon wings getting bright i guess) or your horns break or you get a red halo? well we would need some things for that.

so how to "do holy/unholy" things... maybe we got some things related to the 7 sins/virtues...
i.e. with the quirk you then get a "sacrefice/offering" skill and can click some item... i.e. 2000 credits... if you sacrefice them they burn up in a white flame and you get +1 holy point... and if you "offer them to demons" (might needs better words... sacrefie and sanctify? sacrefy and bless? shrugs) well if you offer the item to unholy you get +1 unholy point. (or -1 on your balance)
so them 2000 credits could be related to "greed" sin then...
maybe making someone cum gives +1 unholy as "lust" sin (everyone is gonna be a demon with that...)
maybe getting pregnant gives +1 holy based on "reverse lust sin"... (but would be bad if demons wouldnt be able to get pregnant then i guess? hmm well maybe demons could "convert the egg/sperm" in them and get +1 unholy instead? that would destroy the egg/sperm in them then. that would be fitting for succubus likes.)

well something for each side:
charity - greed (sacreficeing/offering 2000 credits at a time?)
chastity - lust (sex/pregnancy related things?)
diligence - sloth
humility - pride
kindness - envy
patience - wrath
temperance - gluttony (offering sacreficeing food related items?)

no idea how "balanced" them things should be... i.e. if sacreficeing diamonds or silver or gold from mining could be farmed quickly maybe? or with the 2000cr could be from your job wage... but then again you can steal ro get it from others or from bitcoin machines?... shrugs
i guess there should be some "balance" in a way that all 14 are achivable for everyone and not locked to job items or so.

maybe your "holy/unholy level" could also be added to the scars system and be persistent over rounds for that character.

maybe in a way this could even replace the "cult" mechanics and depending on how many "holy/unholy" characters are on the station the station is "blessed or corrupted"
and holy/unholy characters can "convert normal people" (give them some +1s to their balance if you 1 tile next to someone doing sins/virtues)
i.e. a succubus having sex with someone and corrupting them. or a holy priest giving blessings in the chapel to people (holy hug skill (kindness virtue) that gives mood boost?)
that way random people could get +/- on their balance and maybe every 5 or 10 points in a direction you "level up" your holiness/demoness... and get more powers/bodyparts...
so you (or the random people) might get a popup "you got enough "corruption" to advance to the "fledgeling demon" state... do you want to progress? yes /no
and with yes they get powers and bodyparts of that rank... and with no the "counter" would reset to the previous level. so normal people can stay normal even though they fuck succubi all day... or priest xyz can stay "a priest" and not get angel wings of the next level up... but they can get the 10 points again over time and then get another popup box to decide if they want to stay or level up. maybe even a "dont ask again this shift" checkbox. (i feel that could be usefull if its persistent)

i guess doing these +/- things inside the chapel could give double the holy/corruption points then.

and in a way them two sides "fight eachother" on the station (not open and harmful, more through influenceing/blessing/corrupting others) to change the "holy/unholy balance of the station" (maybe gives a tiny buff to the "stronger side"?)

and maybe the cult runes could be adopted... so holy alinged people can draw holy runes and demons can paint corruption runes... maybe they have to "convert/bless/corrupt" people ontop of them runes similar to converting works for cults.
maybe each "room" on the station could have one special rune either holy or unholy... and these runes count towards the "station alingment" too as +1... where people might count as as much as how high their level is...
i.e. 2 demons level 2 and 4 would add 6 corruption points to the station balance... if there a level 5 angel on station they would add 5 to holy so the station is at -1...
maybe even the station itsself could have "levels"... i.e. at +-10 the chapel glows (stupid example hah)... at +-20 there white/red little particles coming from the floors.
station levels might be a bit much...

@LeDrascol
Copy link
Author

some suggestions for this as this kinda reminds me of cult mechanics... like when they get glowing eyes at some stages.

This is a great suggestion with many practical ideas in it, but will be quite complicated to implement. The concepts of persistent cross-round holy points, separate holy and demon points (New Vegas reputation style), and evolving by performing actions instead of picking quirks could lead to interesting results.

@Zattarra
Copy link

Oh, that's quite interesting. I look forward to the merging of this PR.

@Zattarra Zattarra mentioned this pull request Jun 11, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants