Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transition not working #248

Closed
wants to merge 2 commits into from
Closed

Conversation

wishWinds
Copy link

This will fix transition modifier not working.
The side effect is transition will always animate even if image is load from memory or disk cache.

@dreampiggy
Copy link
Collaborator

I don't think add this into a ObservedObject is suitable...

The correct way maybe put this withAnimation into the WebImage's return body of images

@wishWinds
Copy link
Author

It may has no way to trigger animation within onSuccess callback. the imageManager are internal. and exposing the manager is not a good choice.
What I'm thinking is give a chance to tell the framework using animation when remote image Is come.
I'm thinking add a enableAnimation modifier to WebImage.
If you think this may be a right approach. I will make a new PR!

Thanks.

@zizooom
Copy link

zizooom commented Dec 18, 2022

Thank you

@Ziv-Nergal
Copy link

Any updates on this?
Still not working for me

@aviwad
Copy link

aviwad commented Jul 29, 2023

any update? transition still broken

@alexfanatics
Copy link

I found a workaround here: #272

@wishWinds wishWinds closed this Aug 13, 2023
@wishWinds wishWinds deleted the wishWinds branch August 13, 2023 16:50
@aviwad
Copy link

aviwad commented Aug 13, 2023

why did you close the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants