Update the WebImage API to match SwiftUI.AsyncImage #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
changed the title
dreampiggy
force-pushed
the
api/asyncimage
branch
2 times, most recently
from
b02a80e
to
f7e1b63
Compare
…e), make it more easy to replace The old API is still kept, except the .placeholder one
dreampiggy
force-pushed
the
api/asyncimage
branch
from
f7e1b63
to
9240689
Compare
dreampiggy
changed the title
dreampiggy
force-pushed
the
api/asyncimage
branch
from
9240689
to
c11b4c1
Compare
1. Change the placeholder into Web URL init method (placeholder not works for data/bundle init method) 2. Add convenient .progress/.activity syntax for AnimatedImage indicator
dreampiggy
force-pushed
the
api/asyncimage
branch
from
c11b4c1
to
a94221f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it more easy to replace
SwiftUI.AsyncImagewithWebImageNote: The old API is still kept, except the .placeholder one.
This PR also close #274 and #247 #248
API
Removed:
WebImage.placeholder<T>(@ViewBuilder content: () -> T) -> WebImageWebImage.placeholder(_ image: Image) -> WebImageAnimatedImage.placeholder<T>(@ViewBuilder content: () -> T) -> AnimatedImageAnimatedImage.placeholder(_ image: PlatformImage) -> AnimatedImageUse the init method instead