Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-combobox): enhance storybook samples #7469

Merged
merged 3 commits into from
Sep 1, 2023
+15 −28
Merged

fix(ui5-combobox): enhance storybook samples #7469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2b9891
fix(ui5-combobox): enhance storybook samples
niyap Aug 22, 2023
b6145ff
Merge branch 'main' into comboboxstorybooksamplesupdate
niyap Aug 30, 2023
d6d3e34
fix(ui5-combobox): apply review comments
niyap Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions packages/main/src/ComboBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,15 +267,6 @@ class ComboBox extends UI5Element {

/**
* Defines the value state of the component.
* <br><br>
* Available options are:
* <ul>
* <li><code>None</code></li>
* <li><code>Error</code></li>
* <li><code>Warning</code></li>
* <li><code>Success</code></li>
* <li><code>Information</code></li>
* </ul>
*
* @type {sap.ui.webc.base.types.ValueState}
* @name sap.ui.webc.main.ComboBox.prototype.valueState
Expand Down Expand Up @@ -323,7 +314,6 @@ class ComboBox extends UI5Element {

/**
* Defines the filter type of the component.
* Available options are: <code>StartsWithPerTerm</code>, <code>StartsWith</code>, <code>Contains</code> and <code>None</code>.
*
* @type {sap.ui.webc.main.types.ComboBoxFilter}
* @name sap.ui.webc.main.ComboBox.prototype.filter
Expand Down Expand Up @@ -352,7 +342,7 @@ class ComboBox extends UI5Element {
*
* @type {string}
* @name sap.ui.webc.main.ComboBox.prototype.accessibleName
* @defaultvalue: ""
* @defaultvalue ""
* @public
* @since 1.0.0-rc.15
*/
Expand Down
31 changes: 14 additions & 17 deletions packages/playground/_stories/main/ComboBox/ComboBox.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import ComboBoxFilter from "@ui5/webcomponents/dist/types/ComboBoxFilter.js";
const component = "ui5-combobox";

export default {
title: "Main/ComboBox",
title: "Main/Combo Box",
component: "ComboBox",
subcomponents: {
ComboBoxItem: "ComboBoxItem",
Expand Down Expand Up @@ -54,18 +54,14 @@ export const Basic = Template.bind({});
Basic.args = {
placeholder: "Enter value",
default: `
<ui5-cb-item text="Item 1"></ui5-cb-item>
<ui5-cb-item text="Item 2"></ui5-cb-item>
<ui5-cb-item text="Item 3"></ui5-cb-item>
<ui5-cb-item text="Austria"></ui5-cb-item>
<ui5-cb-item text="Bulgaria"></ui5-cb-item>
<ui5-cb-item text="Germany"></ui5-cb-item>
<ui5-cb-item text="Italy"></ui5-cb-item>
<ui5-cb-item text="Spain"></ui5-cb-item>
`,
};

export const Disabled = Template.bind({});
Disabled.args = {
disabled: true,
value: "Disabled",
};

export const Filters = Template.bind({});
Filters.args = {
placeholder: "Contains Filtering",
Expand All @@ -74,30 +70,31 @@ Filters.args = {
<ui5-cb-item text="Austria"></ui5-cb-item>
<ui5-cb-item text="Bulgaria"></ui5-cb-item>
<ui5-cb-item text="Germany"></ui5-cb-item>
<ui5-cb-item text="United Kingdom"></ui5-cb-item>
<ui5-cb-item text="Kazakhstan"></ui5-cb-item>
<ui5-cb-item text="The United Kingdom of Great Britain and Northern Ireland"></ui5-cb-item>
`,
};

export const TwoColumns = Template.bind({});
TwoColumns.args = {
export const TwoColumnsLayout = Template.bind({});
TwoColumnsLayout.args = {
placeholder: "Two-column layout",
default: `
<ui5-cb-item text="Austria" additional-text="AT"></ui5-cb-item>
<ui5-cb-item text="Belgium" additional-text="BE"></ui5-cb-item>
<ui5-cb-item text="Brazil" additional-text="BR"></ui5-cb-item>
<ui5-cb-item text="Bulgaria" additional-text="BG"></ui5-cb-item>
<ui5-cb-item text="Canada" additional-text="CA"></ui5-cb-item>
<ui5-cb-item text="The United Kingdom of Great Britain and Northern Ireland" additional-text="UK"></ui5-cb-item>
`,
};

export const GroupingItems = Template.bind({});
GroupingItems.args = {
placeholder: "ComboBox with grouping of suggestions",
export const Grouping = Template.bind({});
Grouping.args = {
placeholder: "Grouping of items",
default: `
<ui5-cb-group-item text="A"></ui5-cb-group-item>
<ui5-cb-item text="Argentina"></ui5-cb-item>
<ui5-cb-item text="Australia"></ui5-cb-item>
<ui5-cb-item text="Australia"></ui5-cb-item>
<ui5-cb-item text="Austria"></ui5-cb-item>
<ui5-cb-group-item text="B"></ui5-cb-group-item>
<ui5-cb-item text="Bahrain"></ui5-cb-item>
Expand Down