fix(ui5-combobox): enhance storybook samples #7469
Merged
+15
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyap
requested review from
ndeshev,
MapTo0,
Okiana,
elenastoyanovaa and
ivoplashkov
MapTo0
requested changes
Aug 23, 2023
| placeholder: "ComboBox with grouping of suggestions", | ||
| export const Grouping = Template.bind({}); | ||
| Grouping.args = { | ||
| placeholder: "Grouping of suggestions", |
There was a problem hiding this comment.
I am not sure if suggestions is the right word here. ComboBox provides list of Options (Items technically).
| <ui5-cb-item text="Kazakhstan"></ui5-cb-item> | ||
| <ui5-cb-item text="The United Kingdom of Great Britain and Northern Ireland"></ui5-cb-item> | ||
| <ui5-cb-item text="United Kingdom"></ui5-cb-item> |
There was a problem hiding this comment.
can we change it to something not existing above such as Dryanovo or Yablanitsa?
MapTo0
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #7284
JIRA: BGSOFUIRILA-3683