Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cli client to v2.64.0 #850

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

v0lkc
Copy link
Member

@v0lkc v0lkc commented Jul 15, 2024

Purpose

FIxes #849

Test Cases To Be Updated

  • TestDataSourceDirectories
  • TestDataSourceDirectory
  • TestDataSourceDirectoryEntitlements
  • TestDataSourceDirectoryLabels
  • TestDataSourceDirectoryRole
  • TestDataSourceDirectoryRoleCollection
  • TestDataSourceDirectoryRoleCollections
  • TestDataSourceDirectoryRoles
  • TestDataSourceDirectoryUser
  • TestDataSourceDirectoryUsers
  • TestDataSourceGlobalAccount
  • TestDataSourceGlobalAccountSecuritySettings
  • TestDataSourceGlobalaccountEntitlements
  • TestDataSourceGlobalaccountResourceProvider
  • TestDataSourceGlobalaccountResourceProviders
  • TestDataSourceGlobalaccountRole
  • TestDataSourceGlobalaccountRoleCollection
  • TestDataSourceGlobalaccountRoleCollections
  • TestDataSourceGlobalaccountRoles
  • TestDataSourceGlobalaccountTrustConfiguration
  • TestDataSourceGlobalaccountTrustConfigurations
  • TestDataSourceGlobalaccountUser
  • TestDataSourceGlobalaccountUsers
  • TestDataSourceGlobalaccountWithHierarchy
  • TestDataSourceRegions
  • TestDataSourceSubaccount
  • TestDataSourceSubaccountApp
  • TestDataSourceSubaccountApps
  • TestDataSourceSubaccountEntitlements
  • TestDataSourceSubaccountEnvironmentInstances
  • TestDataSourceSubaccountEnvironments
  • TestDataSourceSubaccountLabels
  • TestDataSourceSubaccountRole
  • TestDataSourceSubaccountRoleCollection
  • TestDataSourceSubaccountRoleCollections
  • TestDataSourceSubaccountRoles
  • TestDataSourceSubaccountSecuritySettings
  • TestDataSourceSubaccountServiceBinding
  • TestDataSourceSubaccountServiceBindings
  • TestDataSourceSubaccountServiceInstance
  • TestDataSourceSubaccountServiceInstances
  • TestDataSourceSubaccountServiceOffering
  • TestDataSourceSubaccountServiceOfferings
  • TestDataSourceSubaccountServicePlan
  • TestDataSourceSubaccountServicePlans
  • TestDataSourceSubaccountSubscription
  • TestDataSourceSubaccountSubscriptions
  • TestDataSourceSubaccountTrustConfiguration
  • TestDataSourceSubaccountTrustConfigurations
  • TestDataSourceSubaccountUser
  • TestDataSourceSubaccountUsers
  • TestDataSourceSubaccounts
  • TestDataSourceWhoami
  • TestResourceDirectory
  • TestResourceDirectoryEntitlement
  • TestResourceDirectoryRoleCollection
  • TestResourceDirectoryRoleCollectionAssignment
  • TestResourceGlobalAccountRoleCollection
  • TestResourceGlobalaccountResourceProvider
  • TestResourceGlobalaccountRoleCollectionAssignment
  • TestResourceGlobalaccountSecuritySettings
  • TestResourceGlobalaccountTrustConfiguration
  • TestResourceRolCollectionAssignment
  • TestResourceSubAccountRoleCollection
  • TestResourceSubaccount
  • TestResourceSubaccountEntitlement
  • TestResourceSubaccountEnvironmentInstance
  • TestResourceSubaccountSecuritySettings
  • TestResourceSubaccountServiceBinding
  • TestResourceSubaccountServiceInstance
  • TestResourceSubaccountSubscription
  • TestResourceSubaccountTrustConfiguration

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x] Other... Please describe: updates the embedded cli client

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@v0lkc v0lkc self-assigned this Jul 15, 2024
@v0lkc v0lkc marked this pull request as draft July 15, 2024 14:49
@v0lkc v0lkc added btpcli Dependency to BTP CLI backend development dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 15, 2024
@v0lkc v0lkc added this to the 1.5.0 milestone Jul 15, 2024
@v0lkc
Copy link
Member Author

v0lkc commented Jul 15, 2024

The drift detection is failing because of the updated api endpoints. There's no way how I could get this check green.

@v0lkc v0lkc marked this pull request as ready for review July 15, 2024 16:05
@v0lkc v0lkc requested a review from lechnerc77 July 15, 2024 16:05
@v0lkc v0lkc enabled auto-merge (squash) July 15, 2024 16:05
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@v0lkc v0lkc merged commit e2c53e5 into main Jul 16, 2024
19 of 21 checks passed
@v0lkc v0lkc deleted the chore(btpcli)/update-client-to-v2.64.0 branch July 16, 2024 05:26
@v0lkc v0lkc mentioned this pull request Jul 16, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
btpcli Dependency to BTP CLI backend development dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update embedded CLI client to latest version
2 participants