Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(refactor): code styling #852

Merged
merged 1 commit into from
Jul 16, 2024
Merged

chore(refactor): code styling #852

merged 1 commit into from
Jul 16, 2024

Conversation

v0lkc
Copy link
Member

@v0lkc v0lkc commented Jul 16, 2024

Purpose

While working on #850 I noticed some deviations in regards of how we name certain functions. This PR solely addresses code styling and doesn't change the behavior of the provider in any way.

  • ran go fmt ./...
  • globalaccount instead of globalAccount
  • subaccount instead of subAccount
  • a few test functions were wrongly named
    • TestResourceRolCollectionAssignment
    • TestResourceSubAccountRoleCollection
    • ...

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@v0lkc v0lkc added the go Pull requests that update Go code label Jul 16, 2024
@v0lkc v0lkc added this to the 1.5.0 milestone Jul 16, 2024
@v0lkc v0lkc enabled auto-merge (squash) July 16, 2024 08:59
@v0lkc v0lkc requested a review from lechnerc77 July 16, 2024 08:59
@lechnerc77 lechnerc77 added the ignore-for-release All things not to be mentioned in release notes label Jul 16, 2024
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@v0lkc v0lkc merged commit 405ec90 into main Jul 16, 2024
27 of 31 checks passed
@v0lkc v0lkc deleted the chore/code-styling branch July 16, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code ignore-for-release All things not to be mentioned in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants