Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling of errors for services, subscriptions and bindings #352

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

lechnerc77
Copy link
Member

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

n/a

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 added the bug Something isn't working label Jul 31, 2023
@lechnerc77 lechnerc77 self-assigned this Jul 31, 2023
@lechnerc77 lechnerc77 requested a review from rui1610 July 31, 2023 09:53
@lechnerc77 lechnerc77 enabled auto-merge (squash) July 31, 2023 09:53
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it so quickly!

@lechnerc77 lechnerc77 merged commit 3280824 into main Jul 31, 2023
12 of 13 checks passed
@lechnerc77 lechnerc77 deleted the fix-service-errors branch July 31, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] failed app subscription not detected for SAP Build Apps
2 participants