Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error handling of entitlement polling #354

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

lechnerc77
Copy link
Member

Purpose

  • This PR fixes the handling of error scenarios when polling for a state change for the resource entitlement.

  • Error that occurs looks basically like this if the entitlement fails:

    When applying changes to btp_subaccount_entitlement.entitlement-quotas["xxx"], 
     provider
     │ "provider["registry.terraform.io/sap/btp"]" produced an unexpected new value: .amount: was cty.NumberIntVal(1), but now  
     │ cty.NumberIntVal(0).

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully

Other Information

see also PR #352

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@lechnerc77 lechnerc77 added the bug Something isn't working label Aug 1, 2023
@lechnerc77 lechnerc77 requested a review from rui1610 August 1, 2023 11:25
@lechnerc77 lechnerc77 self-assigned this Aug 1, 2023
@lechnerc77 lechnerc77 enabled auto-merge (squash) August 1, 2023 11:25
Copy link
Contributor

@rui1610 rui1610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lechnerc77 lechnerc77 merged commit 7b7bf86 into main Aug 1, 2023
12 checks passed
@lechnerc77 lechnerc77 deleted the fix-entitlement-polling branch August 1, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants