Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: align error message punctuation to Terraform best practices #327

Merged
merged 2 commits into from
Jul 25, 2023
Merged

docs: align error message punctuation to Terraform best practices #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b736f4b
docu: align error message punctuation to Terraform best practices
lechnerc77 Jul 25, 2023
788892a
fix: adjustement of test cases for changed import not supported message
lechnerc77 Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/provider/datasource_whoami.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (gen *whoamiDataSource) Read(ctx context.Context, req datasource.ReadReques

user := gen.client.GetLoggedInUser()
if user == nil {
resp.Diagnostics.AddError("No user found", "")
resp.Diagnostics.AddError("No User Found", "")
return
}

Expand Down
2 changes: 1 addition & 1 deletion internal/provider/resource_directory_role_collection_assignment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ func (rs *directoryRoleCollectionAssignmentResource) Delete(ctx context.Context,

func (rs *directoryRoleCollectionAssignmentResource) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) {
resp.Diagnostics.AddError(
"Import not supported",
"Import Not Supported",
"Import is not supported for this resource. Use the resource directory_role_collection instead.",
)
}
2 changes: 1 addition & 1 deletion internal/provider/resource_directory_role_collection_assignment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func TestResourceDirectoryRoleCollectionAssignment(t *testing.T) {
ImportStateId: "05368777-4934-41e8-9f3c-6ec5f4d564b9",
ImportState: true,
ImportStateVerify: true,
ExpectError: regexp.MustCompile(`Import not supported`),
ExpectError: regexp.MustCompile(`Import Not Supported`),
},
},
})
Expand Down
2 changes: 1 addition & 1 deletion internal/provider/resource_globalaccount_role_collection_assignment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func (rs *globalaccountRoleCollectionAssignmentResource) Delete(ctx context.Cont

func (rs *globalaccountRoleCollectionAssignmentResource) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) {
resp.Diagnostics.AddError(
"Import not supported",
"Import Not Supported",
"Import is not supported for this resource. Use the resource globalaccount_role_collection instead.",
)
}
2 changes: 1 addition & 1 deletion internal/provider/resource_globalaccount_role_collection_assignment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func TestResourceGlobalaccountRoleCollectionAssignment(t *testing.T) {
ImportStateId: "anyID",
ImportState: true,
ImportStateVerify: true,
ExpectError: regexp.MustCompile(`Import not supported`),
ExpectError: regexp.MustCompile(`Import Not Supported`),
},
},
})
Expand Down
2 changes: 1 addition & 1 deletion internal/provider/resource_subaccount_role_collection_assignment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ func (rs *subaccountRoleCollectionAssignmentResource) Delete(ctx context.Context

func (rs *subaccountRoleCollectionAssignmentResource) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) {
resp.Diagnostics.AddError(
"Import not supported",
"Import Not Supported",
"Import is not supported for this resource. Use the resource subaccount_role_collection instead.",
)
}
2 changes: 1 addition & 1 deletion internal/provider/resource_subaccount_role_collection_assignment_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func TestResourceRolCollectionAssignment(t *testing.T) {
ImportStateId: "ef23ace8-6ade-4d78-9c1f-8df729548bbf",
ImportState: true,
ImportStateVerify: true,
ExpectError: regexp.MustCompile(`Import not supported`),
ExpectError: regexp.MustCompile(`Import Not Supported`),
},
},
})
Expand Down
Loading